Revert GCC 5 ABI change

[Simon Quigley]

We should merge 0.0.8-2.2 from Debian Sid because it fixes two Debian bugs. One of which is a dependency issue and the other is fixing an FTBFS with GCC 6.

It seems the Ubuntu delta was because of some GCC 5 related changes back in Wily. If these are no longer needed, we can drop the delta and directly sync.

[Simon Quigley (tsimonq2)]

Subscribing Steve Langasek as he was the most recent Ubuntu uploader.

[Simon Quigley (tsimonq2)]

Attached is a debdiff keeping the delta, applicable to 0.0.8-2.1ubuntu2.

[Mattia Rizzolo (mapreri)]

Dropping those changes is tricky, and at the very least requires adding a Conflict on the library package against the v5 version.

Personally I think it's easier/safer to just carry on with this; it would have been better to do this change in Debian by means of a NMU (the package looks unmaintained anyway..).

Uploading...

[Steve Langasek (vorlon)]

The corresponding Debian bug for the ABI change is Debian bug #791040. This was closed by the Debian release team on the grounds that there was no package depending on the library in the Debian archive. There also isn't one in Ubuntu.

It is best to revert the ABI change to match Debian, but we will need to carry a delta to handle the Conflicts/Replaces back against the Ubuntu-renamed package and carry this delta through 18.04.

[Mattia Rizzolo (mapreri)]

Well, this particular merge is done (didn't notice it lacked the LP: ... meta-tag to close the bug).
https://launchpad.net/ubuntu/+source/freehdl/0.0.8-2.2ubuntu1

[Steve Langasek (vorlon)]

But it's an improper merge, and someone should take care of fixing the resulting bug.

[Simon Quigley (tsimonq2)]

Sorry for the delay on this, holidays and such.

I looked at a change that Steve made on another package recently doing the same thing (hmat-oss), and I used that as a model for this fix, adding this bug number. It's applicable to the Ubuntu revision Mattia uploaded (0.0.8-2.2ubuntu1).

Steve, did I do this right?

[Mattia Rizzolo (mapreri)]

mitya57 uploaded an improved patch, now in NEW.

[Launchpad Janitor (janitor)]

This bug was fixed in the package freehdl - 0.0.8-2.2ubuntu2

---------------
freehdl (0.0.8-2.2ubuntu2) zesty; urgency=medium

  * Revert package rename for g++5 ABI transition, since the affected symbols
    were not part of the ABI; and Provide: the renamed package for
    compatibility. These changes can be dropped after the 18.04 release.
    (LP: #1648295)

 -- Simon Quigley <email address hidden> Mon, 26 Dec 2016 14:46:51 -0600