angular table doesn't use the setting of Items Per Page

Bug #1647677 reported by Kenji Ishii
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Vladislav Kuzmin

Bug Description

Currently, the table based on angularjs support the feature of pagination.
However, the number of items by page is used the fixed value(it's 20).

Same as the table based on django, we need to support a personal setting like above.

Kenji Ishii (ken-ishii)
Changed in horizon:
assignee: nobody → Kenji Ishii (ken-ishii)
tags: added: angularjs
tags: added: ux
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/407466

Changed in horizon:
status: New → In Progress
Revision history for this message
Ying Zuo (yingzuo) wrote :

Another patch for fixing this issue: https://review.openstack.org/#/c/219822/

Changed in horizon:
assignee: Kenji Ishii (ken-ishii) → Ying Zuo (yingzuo)
importance: Undecided → Medium
tags: added: pagination
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Ying Zuo (<email address hidden>) on branch: master
Review: https://review.openstack.org/407466
Reason: in favor of patch https://review.openstack.org/#/c/219822/

Changed in horizon:
assignee: Ying Zuo (yingzuo) → Vladislav Kuzmin (vkuzmin-u)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/219822
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c58e5b8779b296d57e30bd547e46322b3d1e8d99
Submitter: Zuul
Branch: master

commit c58e5b8779b296d57e30bd547e46322b3d1e8d99
Author: Cindy Lu <email address hidden>
Date: Wed Feb 24 16:26:31 2016 -0800

    Use items per page setting on Angular tables

    Make NG table get page size from the items per page setting
    instead of a fixed number which is 20.

    The styling of the pagination control is the same as the
    django table with the prev and next links.

    Co-Authored-By: Liuqing Jing <jing.liuqing@99cloud.net>
    Co-Authored-By: Vladislav Kuzmin <email address hidden>

    Change-Id: Ie5307e335ca3251a342d370e7277fe16067f7949
    Closes-Bug: #1647677

Changed in horizon:
status: In Progress → Fix Released
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → rocky-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/559931

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b1

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/queens)

Reviewed: https://review.openstack.org/559931
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=262379f7748096c3b06e4a614fda42ec4a904edf
Submitter: Zuul
Branch: stable/queens

commit 262379f7748096c3b06e4a614fda42ec4a904edf
Author: Cindy Lu <email address hidden>
Date: Wed Feb 24 16:26:31 2016 -0800

    Use items per page setting on Angular tables

    Make NG table get page size from the items per page setting
    instead of a fixed number which is 20.

    The styling of the pagination control is the same as the
    django table with the prev and next links.

    Co-Authored-By: Liuqing Jing <jing.liuqing@99cloud.net>
    Co-Authored-By: Vladislav Kuzmin <email address hidden>

    Change-Id: Ie5307e335ca3251a342d370e7277fe16067f7949
    Closes-Bug: #1647677
    (cherry picked from commit c58e5b8779b296d57e30bd547e46322b3d1e8d99)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.1

This issue was fixed in the openstack/horizon 13.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.