Incorrectly sizes new subwindows when the title bars are disable. 1.90-1 regression
Bug #1646257 reported by
Julián Moreno Patiño
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Terminator |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
From http://
Hi.
I just noticed that a new terminator, is making some subwindows (created
via split of existing subwindow) zero size width or height, when using
disabled option 'show titlebar'.
It works correctly with titlebars enabled.
Everything was working fine in previous version.
Related branches
Changed in terminator: | |
milestone: | none → 2.0 |
Changed in terminator: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Yup, confirmed :(
Interestingly, if you press either Ctrl+Shift+E or Ctrl+Shift+O (but just one of these) multiple times after a fresh start of terminator, the first split is okay, the second is buggy, the third and later splits are okay again.
Also interestingly, in terminatorlib/ titlebar. py update_visibility() line 187-ish if I change self.hide() to self.show() (so that the red title bar is shown) but leave self.label.hide() as is (that is, the label within is not shown) then it's still buggy. Showing the label too fixes the problem. (Note: 'label' is a complex EditableLabel object, not just a plain text label.)