Mahara

Comment ratings are not accessible - aria-hidden still present

Bug #1645188 reported by Ghada El-Zoghbi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Ilya Tregubov
Mahara 17.04.0
16.04
Fix Released
Medium
Unassigned
Mahara 16.04.5
16.10
Fix Released
Medium
Ilya Tregubov
Mahara 16.10.1
17.04
Fix Released
Medium
Ilya Tregubov
Mahara 17.04.0

Bug Description

Mahara: 16.04 (but probably in other versions as well)
Browser: Chrome
OS: Linux
DB: Postgres

Follow up from bug https://bugs.launchpad.net/mahara/+bug/1568611

Screen readers don't read out the text when users tab into the Ratings field: arai-hidden="true" is in the span and therefore not allowing screen readers to read it.

We'll need to apply another patch.

Ghada El-Zoghbi (ghada-z)
Changed in mahara:
assignee: nobody → Ghada El-Zoghbi (ghada-z)
tags: added: accessibility
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7275

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7275
Committed: https://git.mahara.org/mahara/mahara/commit/e80d5d0d007cdefc0cac785281248240b9e8851a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e80d5d0d007cdefc0cac785281248240b9e8851a
Author: Ilya Tregubov <email address hidden>
Date: Mon Nov 28 15:35:10 2016 +1100

Bug 1645188: Remove aria-hidden for comment ratings to make them accessible

behatnotneeded

Change-Id: I96954cf5303454b71c8674eab2286b5d582719c5

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7276

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7277

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7276
Committed: https://git.mahara.org/mahara/mahara/commit/946b0f8f52345c1dbf0d9df5af7227b73725c101
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 946b0f8f52345c1dbf0d9df5af7227b73725c101
Author: Ilya Tregubov <email address hidden>
Date: Mon Nov 28 15:35:10 2016 +1100

Bug 1645188: Remove aria-hidden for comment ratings to make them accessible

behatnotneeded

Change-Id: I96954cf5303454b71c8674eab2286b5d582719c5
(cherry picked from commit e80d5d0d007cdefc0cac785281248240b9e8851a)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7277
Committed: https://git.mahara.org/mahara/mahara/commit/7848db5b0a6bfffa4ba581c8d9bef5b893886ff5
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 7848db5b0a6bfffa4ba581c8d9bef5b893886ff5
Author: Ilya Tregubov <email address hidden>
Date: Mon Nov 28 15:35:10 2016 +1100

Bug 1645188: Remove aria-hidden for comment ratings to make them accessible

behatnotneeded

Change-Id: I96954cf5303454b71c8674eab2286b5d582719c5
(cherry picked from commit e80d5d0d007cdefc0cac785281248240b9e8851a)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.