Add following tables to pt-table-checksum default exclusion list

[Carlos Salguero]

We should exclude by default the following schemas/tables:
mysql.gtid_execution
sys.sys_config
mysql.proc
mysql.inventory
mysql.plugin
percona.* (including checksums, dsns table)
test.*
percona_schema.* (some tools use this schema by default)
We already support this somewhat:
https://www.percona.com/doc/percona-toolkit/2.2/pt-table-checksum.html#cmdoption-pt-table-checksum--replicate
> The replicate table is never checksummed (the tool automatically adds this table to --ignore-tables).

[monty solomon (monty+launchpad)]

I don't understand why the following tables are on your list. I don't think they should be excluded.

sys.sys_config
mysql.proc
mysql.inventory
mysql.plugin
test.*

[monty solomon (monty+launchpad)]

mysql.gtid_execution should be mysql.gtid_executed

[monty solomon (monty+launchpad)]

These tables should be on the list

mysql.gtid_executed
mysql.engine_cost
mysql.server_cost

[monty solomon (monty+launchpad)]

This bug is related to bug 1576916

[Carlos Salguero (carlos-salguero)]

Thanks

El 27/11/2016 17:10, "monty solomon" <email address hidden> escribió:

> This bug is related to bug 1576916
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1642994
>
> Title:
> Add following tables to pt-table-checksum default exclusion list
>
> Status in Percona Toolkit:
> Fix Committed
>
> Bug description:
> We should exclude by default the following schemas/tables:
> mysql.gtid_execution
> sys.sys_config
> mysql.proc
> mysql.inventory
> mysql.plugin
> percona.* (including checksums, dsns table)
> test.*
> percona_schema.* (some tools use this schema by default)
> We already support this somewhat:
> https://www.percona.com/doc/percona-toolkit/2.2/pt-table-
> checksum.html#cmdoption-pt-table-checksum--replicate
> > The replicate table is never checksummed (the tool automatically adds
> this table to --ignore-tables).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/percona-toolkit/+bug/1642994/+subscriptions
>

[monty solomon (monty+launchpad)]

pt-table-checksum is now ignoring tables and databases that it should not ignore and there is no mechanism to not ignore those tables or databases (without editing the source).

The ignore list in pt-table-checksum includes a table that does not exist -- gtid_execution should be gtid_executed.

[Agustín (agustin-gallego)]

Hi Monty,

We reviewed this with Carlos, and agreed that the following changes will be needed:

Change gtid_execution to gtid_executed (but continue to ignore it by default).

Remove mysql.proc from the list of tables ignored by default.

Add mysql.engine_cost and mysql.server_cost to the list of tables ignored by default.

We also discussed having an argument to override these, so there's no need to modify the source code, but it will be a low priority feature.

If you have any other thoughts on this, let us know. I'll work on implementing these changes soon.

Agustín.

[monty solomon (monty+launchpad)]

We use pt-table-checksum to ensure that the master and the slaves are the same. I don't want there to be hidden differences in tables that are not dynamically modified by the server.

The following tables are now being excluded but they should be the same on the master and the slaves but pt-table-checksum is hiding any differences.

sys.sys_config
mysql.proc
mysql.inventory
mysql.plugin
test.*

[monty solomon (monty+launchpad)]

The following tables are still excluded in pt-table-checksum 3.0.3 even though they should be checked

sys.sys_config
mysql.proc
mysql.inventory
mysql.plugin

and the following tables are still not excluded even though they will differ

mysql.gtid_executed (still misnamed gtid_execution)
mysql.engine_cost
mysql.server_cost

Thanks.

[monty solomon (monty+launchpad)]

Can you update the status and reopen this bug?

Thanks.

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-834