The pagination in the notes dialog while editing a page does not leave the first page

[Knut Jackowski]

While using the page editor and inserting a note and using the "Use content from another note" shows a list of notes that could be used for this, with a pagination underneath. When this pagination shows more then one page, it is not possible to select another page than the first. If one tries to do that, the list changes to "No results found" without pagination. It is probably easier understood with the screenshots.

The server logs output the following when trying to access the second page:

[WAR] 93 (lib/view.php:3416) Object of class stdClass could not be converted to int, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
Call stack (most recent first):, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
  * log_message(string(size 54), integer, true, true, string(size 21), integer) at /var/www/lib/errors.php:521, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
  * error(integer, string(size 54), string(size 21), integer, array(size 14)) at /var/www/lib/view.php:3416, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
  * View::get_artefactchooser_artefacts(array(size 17), object(LiveUser), object(stdClass), null) at /var/www/lib/view.php:3181, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
  * View::build_artefactchooser_data(array(size 16), object(stdClass), null) at /var/www/view/artefactchooser.json.php:26, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254
, referer: https://mahara.uni-koblenz.de/view/blocks.php?id=11254

[Kristina Hoeppner (kris-hoeppner)]

Can you please let us know what version of Mahara you are on and which browser you are using?

[Knut Jackowski (kjackowski)]

Mahara Version: 16.10.0 but was also in 16.04.3 so no regression
Browsers:
- Firefox 49.0.2
- Google Chrome 54.0.2840.71 (64-bit)
- Midori 0.5.11
- Safari 10.0

[Niranjan (niranjan528)]

I have tested this on 16.10.0 with the following browsers

-Firefox 49.0 ( ubuntu and Sauce lab)
- Chrome 53.0.2785.143 (Built on Ubuntu & saucelab same version
-Safari 10.0

But I could replicate it on any of the browser, I am able to select all the pages and I am able to see the notes as well.

Cheers,
Niranjan

[Kristina Hoeppner (kris-hoeppner)]

Hi Knut. That was meant to say "Couldn't replicate it".

Can you please give it a go on https://demo.mahara.org ?

Do you have any customizations in your code?

Cheers
Kristina

[Knut Jackowski (kjackowski)]

Hi, Kristina!

I also had problems replicating it on another Mahara installation and found an additional condition for this bug to happen:

at least one of the notes that are in the list has to be from a page that is
created in a group.

Cheers,

Knut

[Knut Jackowski (kjackowski)]

With notes from groups the behaviour is also to be found in demo.mahara.org.

[Niranjan (niranjan528)]

I could replicate it now by following the above steps.

Steps to reproduce:

1) Create a group and create a page
2) Add few Notes into page 1
3) Now create another page in the same group
4) And add few notes to the second page too( make sure you have more than 6 Notes in total)
5) Now Click on "USe Content from another one"
6) Click on Second page

Result: It says No results found as in the above screenshot

CC: Knut Jackowski, Kristina Hoeppner (kris-hoeppner)

[Robert Lyon (robertl-9)]

Te patch here https://reviews.mahara.org/#/c/7191/ should fix the issue in this bug as well

[Richard Schütz (rschuetz)]

I gave the patch a try and can confirm that it fixes the issue.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7191
Committed: https://git.mahara.org/mahara/mahara/commit/88b94532101fd84acf132779a1dc1ad89f74188d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 88b94532101fd84acf132779a1dc1ad89f74188d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 21 10:06:56 2016 +1300

Bug 1565199: Filter Recent Journals block Add entry + errors

In the block Recent journal entries, the drop-down menu
only shows the Journals which the user has permission to
add a new entry.

Also corrected error showing up and broken Journal search
in the Edit block side screen.

Also fixed the poor alignment of the artefactchoooser search form's
search button

Also fixes Bug 1636850 with change in lib/view.php

behatnotneeded

Change-Id: I44c0d6d25eda7cb37d4a8aab66a6d1b93ca60b69

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7252

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7252
Committed: https://git.mahara.org/mahara/mahara/commit/e08db4cd65c277d77eb658b33447779a8985c362
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit e08db4cd65c277d77eb658b33447779a8985c362
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 21 10:06:56 2016 +1300

Bug 1565199: Filter Recent Journals block Add entry + errors

In the block Recent journal entries, the drop-down menu
only shows the Journals which the user has permission to
add a new entry.

Also corrected error showing up and broken Journal search
in the Edit block side screen.

Also fixed the poor alignment of the artefactchoooser search form's
search button

Also fixes Bug 1636850 with change in lib/view.php

behatnotneeded

Change-Id: I44c0d6d25eda7cb37d4a8aab66a6d1b93ca60b69
(cherry picked from commit 88b94532101fd84acf132779a1dc1ad89f74188d)