segment fault when running fwts method test

[Ivan Hu]

[SRU Justification][YAKKETY]

fwts segfaults when running a fwts method test because of a double unlock on a pthread mutex.

[FIX]
Upstream commit https://lists.ubuntu.com/archives/fwts-devel/2016-October/008679.html - don't do double unlocking

[TEST CASE]
run fwts method - on the firmware and we get a double unlock on method invocation accounting and a segfault occurs. With the fix there is no segfault.

[REGRESSION POTENTIAL]
Minimal impact; this affects method invocation accounting and just the fwts method execution. The fix only changes the accounting and will not affect other fwts test components.

------------------------------------------------

Test 46 of 192: Test _OFF (Set resource off).
PASSED: Test 46, \_SB_.PCI0.PEG0.PEGP._OFF returned no values as expected.
Caught SIGNAL 11 (Segmentation fault), aborting.
Backtrace:
0x00007f09c3fc9dd4 /usr/local/lib/fwts/libfwts.so.1(+0xfdd4)
0x00007f09c3a1b4a0 /lib/x86_64-linux-gnu/libc.so.6(+0x354a0)
0x00007f09c3363960 /lib/x86_64-linux-gnu/libpthread.so.0(+0x12960)
0x00007f09c42196b0 /usr/local/lib/fwts/libfwtsacpica.so.1(fwts_acpica_sem_count_get+0x40)
0x000000000041efef fwts()
0x000000000041f195 fwts()
0x0000000000421210 fwts()
0x00007f09c3fcf441 /usr/local/lib/fwts/libfwts.so.1(+0x15441)
0x00007f09c3fd0bc3 /usr/local/lib/fwts/libfwts.so.1(fwts_framework_args+0x793)
0x000000000040519a fwts()
0x00007f09c3a06830 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)
0x0000000000406079 fwts()

[Ivan Hu (ivan.hu)]

Fix sent to fwts developer mailing list for review
https://lists.ubuntu.com/archives/fwts-devel/2016-October/008679.html

[Andy Whitcroft (apw)]

Hello Ivan, or anyone else affected,

Accepted fwts into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwts/16.09.00-0ubuntu4.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Andy Whitcroft (apw)]

Hello Ivan, or anyone else affected,

Accepted fwts into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwts/16.03.00-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Andy Whitcroft (apw)]

Hello Ivan, or anyone else affected,

Accepted fwts into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwts/14.03.01-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Colin Ian King (colin-king)]

@Ivan, if you can send me an ACPI dump of the machine that triggers this I can verify that the fix works on the various releases.

[Ivan Hu (ivan.hu)]

@Colin,

I've tried acpidump log last week but cannot reproduce the issue.
Unfortunately, I cannot get the machine which can reproduce the issue, since the QA has been testing with it last week and not allow me to touch it. I need to wait for a week after QA finish testing.

[Ivan Hu (ivan.hu)]

verify with fwts V16.09.00 with Yakkety-proposed, Xenial-proposed, Trusty-proposed,

All pass with fwts method tests.

[Colin Ian King (colin-king)]

Thanks Ivan!

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwts - 16.09.00-0ubuntu4.1

---------------
fwts (16.09.00-0ubuntu4.1) yakkety; urgency=low

  * fix segment fault when running fwts method test (LP: #1635502)
    - remove double pthread_mutex_unlock on method usage thread counter

 -- Colin King <email address hidden> Fri, 21 Oct 2016 09:27:32 +0100

[Chris J Arges (arges)]

The verification of the Stable Release Update for fwts has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwts - 16.03.00-0ubuntu1.1

---------------
fwts (16.03.00-0ubuntu1.1) xenial; urgency=low

  * fix segment fault when running fwts method test (LP: #1635502)
    - remove double pthread_mutex_unlock on method usage thread counter

 -- Colin King <email address hidden> Mon, 24 Oct 2016 17:21:11 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwts - 14.03.01-0ubuntu4

---------------
fwts (14.03.01-0ubuntu4) trusty; urgency=low

  * fix segment fault when running fwts method test (LP: #1635502)
    - remove double pthread_mutex_unlock on method usage thread counter
  * minor wiggle of patches in debian/patches

 -- Colin King <email address hidden> Mon, 24 Oct 2016 18:05:14 +0100