[xenial] search domains in networkd do not get propagated to resolvconf

[Martin Pitt]

Search domains specified in networkd do not get propagated to /etc/resolv.conf via resolved in xenial, as systemd-networkd-resolvconf-update.service only tells resolvconf about DNS servers. This is not an issue any more in yakkety and zesty as that uses resolved and that unit is gone.

This was uncovered while working on adding nameserver support to netplan, in bug 1626617. To fully support netplan/networkd in xenial we should fix this.

SRU TEST CASE:
 * Start a xenial VM or container, and create a networkd interface with a DNS server and search domain:

$ cat /etc/systemd/network/foo.netdev
[NetDev]
Name=foo
Kind=dummy

$ cat /etc/systemd/network/foo.network
[Match]
Name=foo

[Network]
DNS=1.2.3.4
Domains=kitchen cellar

 * sudo systemctl restart systemd-networkd

 * cat /etc/resolv.conf

resolv.conf should have "nameserver 1.2.3.4" (unless there already are three nameservers), but with the current xenial version it lacks "search kitchen cellar". With the -proposed version, both entries should be there.

REGRESSION POTENTIAL: This makes the shell hack of systemd-networkd-resolvconf-update.service even worse, so errors in it could break the existing "nameserver" integration of networkd with resolved. On xenial this is only really relevant with netplan and snappy (see bug 1626617), so the number of installations that actually use this in the field should be low. But this is simple enough to test in isolation, systemd's autopkgtest already cover the "nameserver" resolvconf integration, and netplan's autopkgtest now cover both "nameserver" and "search". So overall the regression potential is very limited.

[Martin Pitt (pitti)]

Fixed in https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?h=ubuntu-xenial&id=7168785fb155

[Andy Whitcroft (apw)]

Hello Martin, or anyone else affected,

Accepted nplan into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nplan/0.13~16.04 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Martin Pitt (pitti)]

Please ignore the previous message. The above nplan does not fix this bug, it just disables that particular check in its testsuite until the fix lands.

[Chris J Arges (arges)]

Hello Martin, or anyone else affected,

Accepted systemd into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/229-4ubuntu12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Martin Pitt (pitti)]

I exercised the test case and this now works as intended.

[Martin Pitt (pitti)]

The verification of the Stable Release Update for nplan has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package systemd - 229-4ubuntu12

---------------
systemd (229-4ubuntu12) xenial; urgency=medium

  * unit: sent change signal before removing the unit if necessary
    (LP: #1632964)
  * networkd: Fix assertion crash on adding VTI with IPv6 addresses
    (LP: #1633274)
  * systemd-networkd-resolvconf-update.service: Propagate search domains
    (LP: #1635256)

 -- Martin Pitt <email address hidden> Wed, 26 Oct 2016 13:18:42 +0200