View Temporary/My Lists from Record Summary

[Christine Morgan]

In the public opac, there currently isn't a way to access your temporary list from the record summary screen. You need to back up to the search results to find the "View My List" button.

[Christine Morgan (cmorgan-z)]

This patch / branch adds a link to the record summary screen that allows you to view your temporary list or, if logged in, view all your lists.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cmorgan/lp1628966_view_temporary_list

[Terran McCanna (tmccanna)]

Christine, did you remove the pullrequest because it wasn't working the way you wanted it to?

[Kathy Lussier (klussier)]

Hi Terran,

We noticed an issue with the git branch after posting it, but didn't have time to resolve it before leaving for the day. We're going to revisit it next week and re-add the pullrequest tag at that time.

[Remington Steed (rjs7)]

A quick comment based only on reading the code (and on the clue that this was one of the four branches that might have caused an error on the test server yesterday):

It looks like there's an extra [% END %] at the end of the following added section:

<div class="rdetail_aux_utils toggle_list">
    [% IF ctx.mylist.size %]
        [%- IF ctx.user; %]
        <a href="[% mkurl(ctx.opac_root _ '/myopac/lists') %]" class="no-dec" rel="nofollow" vocab=""><img src="[% ctx.media_prefix %]/images/clipboard.png" alt="[% l('View My Lists') %]" />[% l(' View My Lists') %]</a>
        [%- ELSE %]
        <a href="[% mkurl(ctx.opac_root _ '/mylist') %]" class="no-dec" rel="nofollow" vocab=""><img src="[% ctx.media_prefix %]/images/clipboard.png" alt="[% l('View My Temporary List') %]" />[% l(' View My Temporary List') %]</a>
        [%- END %]
    [% END %]
[% END %] <---- **** POSSIBLE CAUSE OF ERROR ****
</div>

[Christine Morgan (cmorgan-z)]

Thanks! You are correct. That is an extra [% END %]. Will correct it when
we revisit next week.

On Fri, Sep 30, 2016 at 9:21 AM, Remington Steed <email address hidden> wrote:

> A quick comment based only on reading the code (and on the clue that
> this was one of the four branches that might have caused an error on the
> test server yesterday):
>
> It looks like there's an extra [% END %] at the end of the following
> added section:
>
> <div class="rdetail_aux_utils toggle_list">
> [% IF ctx.mylist.size %]
> [%- IF ctx.user; %]
> <a href="[% mkurl(ctx.opac_root _ '/myopac/lists') %]"
> class="no-dec" rel="nofollow" vocab=""><img src="[% ctx.media_prefix
> %]/images/clipboard.png" alt="[% l('View My Lists') %]" />[% l(' View My
> Lists') %]</a>
> [%- ELSE %]
> <a href="[% mkurl(ctx.opac_root _ '/mylist') %]" class="no-dec"
> rel="nofollow" vocab=""><img src="[% ctx.media_prefix
> %]/images/clipboard.png" alt="[% l('View My Temporary List') %]" />[% l('
> View My Temporary List') %]</a>
> [%- END %]
> [% END %]
> [% END %] <---- **** POSSIBLE CAUSE OF ERROR ****
> </div>
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1628966
>
> Title:
> View Temporary/My Lists from Record Summary
>
> Status in Evergreen:
> Confirmed
>
> Bug description:
> In the public opac, there currently isn't a way to access your
> temporary list from the record summary screen. You need to back up to
> the search results to find the "View My List" button.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1628966/+subscriptions
>

--
Christine Morgan
Database Support Analyst
North of Boston Library Exchange, Inc.
Danvers, Massachusetts
<email address hidden>

[Christine Morgan (cmorgan-z)]

The issue has been corrected. Same branch. Thanks!

[Terran McCanna (tmccanna)]

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address <email address hidden>.

[Kathy Lussier (klussier)]

I resolved conflicts with current master and pushed a signed-off, rebased branch to http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cmorgan/lp1628966_view_temporary_list

[Kathy Lussier (klussier)]

Bah! Bad copy and paste. The rebased branch is at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1628966_view_temporary_list_signoff