Able to select a standard from Collection Edit page

Bug #1625380 reported by LIsa
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon

Bug Description

Tested in Chrome, Firefox, Safari and IE Edge for php5

Pre req: Confirm that standard is pre selected via SE map/matrix (Collection>matrix>annotation)
         From standard drop down menu, pre selected is highlighted and not able to select a diff standard

Test step:
From Page>Edit this page>Annotation (enter Annotation)
Standard drop down menu>select a standard (different from existing)
Save

To confirm that the change is accepted: Collection>matrix>Annotation

You should not be able to update the standard once it had already been selected as the annotation wouldn't fit anymore. This is a bug.

Revision history for this message
LIsa (lisadunmire) wrote :
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

When an annotation is added via the SmartEvidence map, the standard cannot be changed, but it can still be changed when you open the "Annotation" block from the page.

Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 16.10.0
tags: added: smartevidence
Revision history for this message
Robert Lyon (robertl-9) wrote :

Currently the adding annotations works like this:

1) If a user adds an annotation to a page via clicking on a matrix point then they can't choose another standard option because the annotation block's standard is paired to the matrix point chosen.

We stop the ability to choose a different standard here because the code to handle this would be overly complicated and UX confusing (click 1 point and another updates). It is not because it breaks any rules.

2) If a user adds an annotation to a page via editing the page then they can choose any standard they want.

3) If a user edits an annotation on a page via editing the page, whether the annotation was added via matrix or via editing page, then they can choose any standard they want and it will update things accordingly.

I think it should be allowed to edit an annotation block and set it to be another standard if required - but only before any feedback/assessment has been done.

Once the assessment changes or feedback is placed on the annotation then changing the standard should be disallowed.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7028

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
status: Confirmed → Fix Committed
Changed in mahara:
status: Fix Committed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7028
Committed: https://git.mahara.org/mahara/mahara/commit/70a3b094cd1f836afa18ea4847817509951ae5cf
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 70a3b094cd1f836afa18ea4847817509951ae5cf
Author: Robert Lyon <email address hidden>
Date: Mon Sep 26 14:13:11 2016 +1300

Bug 1625380: Stopping an annotation being set to another standard

If the annotation has feedback and/or assessment set to something
other than 'begun'

behatnotneeded

Change-Id: I1a97e91c453628d1f79a09ef8ee588ac1829f163
Signed-off-by: Robert Lyon <email address hidden>

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7156

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7156
Committed: https://git.mahara.org/mahara/mahara/commit/a1924752aaafd90a35e1069a07c5d7b9006ee4ab
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit a1924752aaafd90a35e1069a07c5d7b9006ee4ab
Author: Robert Lyon <email address hidden>
Date: Mon Sep 26 14:13:11 2016 +1300

Bug 1625380: Stopping an annotation being set to another standard

If the annotation has feedback and/or assessment set to something
other than 'begun'

behatnotneeded

Change-Id: I1a97e91c453628d1f79a09ef8ee588ac1829f163
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 70a3b094cd1f836afa18ea4847817509951ae5cf)

tags: added: usermanualupdate
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
tags: removed: usermanualupdate
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.