Valid URL(www) is not accepted while saving Books and publications

Bug #1624153 reported by Niranjan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

Tested in

Version 16.04 & Version 16.10

Theme: Ocean and default

Browser: FF, chrome

Steps to Reproduce:

1) Navigate to Content>Reseme>Achievements
2) Click on add under Books and Publications
3) Enter the mandatory fields and also add a valid URL ( I have used www.facebook.com)
4) Click on save

Expected result: The page should be saved
Actual Result: Bug one: An error message is displayed " Not a Valid URL"

Note: When www is replaced with http or https the page is saved successfully. And when we re-edit the URL back to www it accepts it

Bug two: After saving the page try to re-edit and click on any of the help icon, it doesn't show the information and instead it displays an error message ( see attached )

Note: Similarly help icon doesn't show the information on " professional memberships " too

Revision history for this message
Niranjan (niranjan528) wrote :
Niranjan (niranjan528)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6985

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 16.10.0
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6985
Committed: https://git.mahara.org/mahara/mahara/commit/6cf961724370d47e2ebe751e6e8bb7881f0ea8cd
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 6cf961724370d47e2ebe751e6e8bb7881f0ea8cd
Author: Robert Lyon <email address hidden>
Date: Sat Sep 17 13:54:50 2016 +1200

Bug 1624153: Better url checking for resume book form

This fix deals with a better checking of the supplied url and making
sure it is validated on both the addbook form and editcomposite form

Also fixing the help message issues when on editcomposite.php page

behatnotneeded - existing tests should be ok

Change-Id: I8d9e26dcf71f6bc2b3953a5548c3426efb2d459b
Signed-off-by: Robert Lyon <email address hidden>

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7024

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7024
Committed: https://git.mahara.org/mahara/mahara/commit/7727dd6260f9fac34a5a6e7306a80b3864df820c
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 7727dd6260f9fac34a5a6e7306a80b3864df820c
Author: Robert Lyon <email address hidden>
Date: Sat Sep 17 13:54:50 2016 +1200

Bug 1624153: Better url checking for resume book form

This fix deals with a better checking of the supplied url and making
sure it is validated on both the addbook form and editcomposite form

Also fixing the help message issues when on editcomposite.php page

behatnotneeded - existing tests should be ok

Change-Id: I8d9e26dcf71f6bc2b3953a5548c3426efb2d459b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6cf961724370d47e2ebe751e6e8bb7881f0ea8cd)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.