ActionSelectionPopover broken in latest UITK release

[Olivier Tilloy]

I upgraded packages on my laptop today (xenial + stable overlay PPA) and builds of lp:webbrowser-app started failing in tst_QmlTests.

Those are the failures I’m seeing:

FAIL! : QmlTests::NewTabView::test_delete_top_site() Uncaught exception: Cannot read property 'x' of undefined
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/WebbrowserTestCase.qml(26)]
FAIL! : QmlTests::NewTabView::test_expand_bookmarks() 'verify()' returned FALSE. ()
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/tst_NewTabView.qml(82)]
FAIL! : QmlTests::NewTabView::test_keyboard_navigation() 'verify()' returned FALSE. ()
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/tst_NewTabView.qml(82)]
FAIL! : QmlTests::NewTabView::test_keyboard_navigation() 'verify()' returned FALSE. ()
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/tst_NewTabView.qml(189)]
FAIL! : QmlTests::TabsBar::test_context_menu_close() Uncaught exception: Cannot read property 'x' of undefined
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/WebbrowserTestCase.qml(26)]
FAIL! : QmlTests::TabsBar::test_context_menu_new_tab() Uncaught exception: Cannot read property 'x' of undefined
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/WebbrowserTestCase.qml(26)]
FAIL! : QmlTests::TabsBar::test_context_menu_reload() Uncaught exception: Cannot read property 'x' of undefined
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/WebbrowserTestCase.qml(26)]
FAIL! : QmlTests::TabsBar::test_menu_states_on_new_tab() Uncaught exception: Cannot read property 'enabled' of null
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/tst_TabsBar.qml(245)]
FAIL! : QmlTests::TabsBar::test_menu_states_on_page() Uncaught exception: Cannot read property 'enabled' of null
   Loc: [/build/webbrowser-app/trunk/tests/unittests/qml/tst_TabsBar.qml(256)]

[Olivier Tilloy (osomon)]

This is the list of packages that got upgraded:

qtdeclarative5-ubuntu-ui-toolkit-plugin:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
liboxideqt-qmlplugin:amd64 (1.16.8-0ubuntu0.16.04.1~overlay1, 1.17.7-0ubuntu0.16.04.1)
mediascanner2.0:amd64 (0.111+16.04.20160526-0ubuntu1, 0.112+16.04.20160909-0ubuntu1)
unity-schemas:amd64 (7.4.0+16.04.20160801.2-0ubuntu1, 7.4.0+16.04.20160906-0ubuntu1)
liboxideqtquick0:amd64 (1.16.8-0ubuntu0.16.04.1~overlay1, 1.17.7-0ubuntu0.16.04.1)
qml-module-ubuntu-test:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
libtelepathy-qt4-2:amd64 (0.9.6.1-7ubuntu2~xenial, 0.9.6.1-9ubuntu6~xenial)
ubuntu-ui-toolkit-tools:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
liboxideqtcore0:amd64 (1.16.8-0ubuntu0.16.04.1~overlay1, 1.17.7-0ubuntu0.16.04.1)
libtelepathy-qt5-0:amd64 (0.9.6.1-7ubuntu2~xenial, 0.9.6.1-9ubuntu6~xenial)
ubuntu-ui-toolkit-autopilot:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
bamfdaemon:amd64 (0.5.3~bzr0+16.04.20160701-0ubuntu1, 0.5.3~bzr0+16.04.20160824-0ubuntu1)
libthumbnailer-qt-dev:amd64 (2.4+16.04.20160719-0ubuntu1, 2.4+16.04.20160825-0ubuntu1)
libsystemd0:amd64 (229-4ubuntu7, 229-4ubuntu8)
libsystemd0:i386 (229-4ubuntu7, 229-4ubuntu8)
adobe-flash-properties-gtk:amd64 (1:20160712.1-0ubuntu0.16.04.1, 1:20160913.1-0ubuntu0.16.04.1)
thumbnailer-service:amd64 (2.4+16.04.20160719-0ubuntu1, 2.4+16.04.20160825-0ubuntu1)
gir1.2-click-0.4:amd64 (0.4.43+16.04.20160203-0ubuntu2, 0.4.45+16.04.20160828.1-0ubuntu1)
qtdeclarative5-ubuntu-download-manager0.1:amd64 (1.3+16.04.20160812.2-0ubuntu1, 1.3+16.04.20160909.1-0ubuntu1)
ubuntu-app-launch-profiler:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
click:amd64 (0.4.43+16.04.20160203-0ubuntu2, 0.4.45+16.04.20160828.1-0ubuntu1)
libudm-common1:amd64 (1.3+16.04.20160812.2-0ubuntu1, 1.3+16.04.20160909.1-0ubuntu1)
udev:amd64 (229-4ubuntu7, 229-4ubuntu8)
libubuntu-download-manager-client1:amd64 (1.3+16.04.20160812.2-0ubuntu1, 1.3+16.04.20160909.1-0ubuntu1)
libnet-cpp2:amd64 (2.0.0-0ubuntu1, 2.1.0+16.04.20160913.2-0ubuntu1)
unity:amd64 (7.4.0+16.04.20160801.2-0ubuntu1, 7.4.0+16.04.20160906-0ubuntu1)
qml-module-ubuntu-performancemetrics:amd64 (1.3.2073+16.04.20160824build1~~xenialoverlay1~1, 1.3.2085+16.04.20160831.4)
phablet-tools:amd64 (1.2.1+16.04.20160906-0ubuntu1, 1.2.1+16.04.20160913-0ubuntu1)
qml-module-ubuntu-mediascanner0.1:amd64 (0.111+16.04.20160526-0ubuntu1, 0.112+16.04.20160909-0ubuntu1)
qtdeclarative5-ubuntu-mediascanner0.1:amd64 (0.111+16.04.20160526-0ubuntu1, 0.112+16.04.20160909-0ubuntu1)
libudm-priv-common1:amd64 (1.3+16.04.20160812.2-0ubuntu1, 1.3+16.04.20160909.1-0ubuntu1)
libudev1:amd64 (229-4ubuntu7, 229-4ubuntu8)
libudev1:i386 (229-4ubuntu7, 229-4ubuntu8)
gtk2-engines-murrine:amd64 (0.98.2-0ubuntu2.1, 0.98.2-0ubuntu2.2)
adobe-flashplugin:amd64 (1:20160712.1-0ubuntu0.16.04.1, 1:20160913.1-0ubuntu0.16.04.1)
libbamf3-2:amd64 (0.5.3~bzr0+16.04.20160701-0ubuntu1, 0.5.3~bzr0+16.04.20160824-0ubuntu1)
qtdeclarative5-ubuntu-thumbnailer0.1:amd64 (2.4+16.04.20160719-0ubuntu1, 2.4+16.04.2...

[Olivier Tilloy (osomon)]

It looks like this could be a regression in the UITK. The following standalone example doesn’t work as expected (the popover is only a few pixels tall, no action is visible):

import QtQuick 2.4
import Ubuntu.Components 1.3
import Ubuntu.Components.Popups 1.3
MouseArea {
  id: root
  width: units.gu(50)
  height: units.gu(50)
  Component {
    id: menuFactory
    ActionSelectionPopover {
      actions: ActionList {
        Action {
          text: "foo"
        }
        Action {
          text: "bar"
        }
      }
    }
  }
  onClicked: PopupUtils.open(menuFactory, root)
}

[Olivier Tilloy (osomon)]

https://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/staging/revision/2077 is what broke ActionSelectionPopover in the UITK.

[Olivier Tilloy (osomon)]

And I can confirm that all 9 unit test failures in tst_QmlTests in webbrowser-app are gone when reverting to revision 2076 of the UITK’s staging branch.

[Olivier Tilloy (osomon)]

Zsombor asked me to test the following patch, which appears to fix the issue: http://pastebin.ubuntu.com/23181724/

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2085+16.10.20160915

---------------
ubuntu-ui-toolkit (1.3.2085+16.10.20160915) yakkety; urgency=medium

  [ Zsombor Egri ]
  * Fix ActionList API break. (LP: #1623841)

 -- Zoltán Balogh <email address hidden> Thu, 15 Sep 2016 15:17:27 +0000