Existing annotations throw warning due to missing evidence

[Robert Lyon]

As we added annotation plugin a while back those annotations do not have an evidence value set for them.

We need to take that into account when rendering their feedback

Call stack (most recent first):

    log_message("Trying to get property of non-object", 8, true, true, "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278) at /var/www/html/mahara/htdocs/lib/errors.php:513
    error(8, "Trying to get property of non-object", "/var/www/html/mahara/htdocs/artefact/annotation/li...", 1278, array(size 11)) at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1278
    ArtefactTypeAnnotationfeedback::add_annotation_feedback_form(object(ArtefactTypeAnnotation), object(View), null, "108", false, "0") at /var/www/html/mahara/htdocs/artefact/annotation/lib.php:1132

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6976

[Robert Lyon (robertl-9)]

When we have this situation:

1) an older site - say 16.04
2) annotation block enabled/active in Admmin -> Extensions
3) add some annotation blocks to a page
4) leave feedback on annotation blocks

And we upgrade to master and then do:

1) install/activate smartevidence
2) allow smart evidence to the institution the above user/page is in
3) add the page into a collection and choose a smart evidence framework for it

When we go to view the page we get 'property of non-object' errors

This is because the code expected all annotations to have an evidence level set

I've added check for this now

[Robert Lyon (robertl-9)]

What would be also good to have is for some way to set old annotations to join with a SE matrix point

[Robert Lyon (robertl-9)]

Ah, Ignore last message - there already is a way - just edit the block and pick a smart evidence standard :)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6976
Committed: https://git.mahara.org/mahara/mahara/commit/1adfbdc6ecee0accc0375b96102e0e9dfe09be07
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 1adfbdc6ecee0accc0375b96102e0e9dfe09be07
Author: Robert Lyon <email address hidden>
Date: Wed Sep 14 13:48:17 2016 +1200

Bug 1623282: property of non-object error for old annotations

When the old annotations have feedback on them

behatnotneeded

Change-Id: I1325ebf9d3067065730442b81c885d5b7178c777
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7025

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7025
Committed: https://git.mahara.org/mahara/mahara/commit/58badae96b1a53a8b9322ff1c7c91c5ec4a16e04
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 58badae96b1a53a8b9322ff1c7c91c5ec4a16e04
Author: Robert Lyon <email address hidden>
Date: Wed Sep 14 13:48:17 2016 +1200

Bug 1623282: property of non-object error for old annotations

When the old annotations have feedback on them

behatnotneeded

Change-Id: I1325ebf9d3067065730442b81c885d5b7178c777
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1adfbdc6ecee0accc0375b96102e0e9dfe09be07)