SDK click review errors due to missing apparmor-easyprof-ubuntu.json

[SiCoe]

Error shows on fresh install of the ubuntu SDK.

Running the "Build and validate click package" within the Publish tab on SDK shows error at bottom of log:

Error: Traceback (most recent call last):
  File "/usr/bin/click-review", line 162, in <module>
    main()
  File "/usr/bin/click-review", line 156, in main
    results.run_all_checks(overrides)
  File "/usr/bin/click-review", line 105, in run_all_checks
    section = self._run_module_checks(module, overrides)
  File "/usr/bin/click-review", line 97, in _run_module_checks
    review.do_checks()
  File "/usr/lib/python3/dist-packages/clickreviews/common.py", line 384, in do_checks
    func()
  File "/usr/lib/python3/dist-packages/clickreviews/cr_security.py", line 691, in check_policy_groups
    if len(policy_groups) < 1:
TypeError: object of type 'NoneType' has no len()

This is caused by the apparmour-easyprof-ubuntu.json file missing from my home folder's .cache/click-reviewers-tools/

The SDK should download it if it's missing but the address it uses is: http://bazaar.launchpad.net/~click-reviewers/click-reviewers-tools/trunk/download/head:/apparmoreasyprofubun-20140711222314-oeohtxzvf9a58fa6-1/apparmor-easyprof-ubuntu.json and this link currently returns 404.

On putting a copy of the apparmour-easyprof-ubuntu.json file in the .cache/click-reviewers-tools/ folder, the error goes away.

[Stuart Langridge (sil)]

The issue is in http://bazaar.launchpad.net/~store-reviewers/click-reviewers-tools/trunk/view/head:/clickreviews/apparmor_policy.py which has the above URL in.

[Zoltan Balogh (bzoltan)]

The JSON file is back it seems. Easy fix it was.

[Stuart Langridge (sil)]

The bug is that the SDK relies on a file on the network being present and won't work without it, which breaks if the file disappears or the network isn't available. Putting the file back on the network doesn't really solve the problem :-) Shipping a "backup" copy of this file in the package and falling back to it if the network isn't available or the file vanished would solve it...

[Jamie Strandboge (jdstrand)]

The way it is supposed to work is that the tools fetch it the first time, then if the network is done they will continue using it. However, clearly the first use is a problem. We can ship the file and fallback to using it in this case.

[Jamie Strandboge (jdstrand)]

Marking this as Won't Fix since the review tools won'tbe getting updates for click and snap v1 any more.