multipathd reconfigure does not update /etc/multipath/wwids file on trusty

[Louis Bouchard]

[Description of the problem]
[SRU justification]
When running "multipathd reconfigure", which is done when one does a "service multipath-tools restart", the file /etc/multipath/wwids does not get updated with the wwid entries. Only the header is found.

[Impact]
The content of the file may contain stale values or remain with only the file header if the file was removed.

[Fix]
Add a call to remember_wwid(mpp->wwid)

[Test Case]
With an up-to-date Trusty system running multipath-tools-0.4.9-3ubuntu7.13 do the following :

$ sudo cat /etc/multipath/wwids
# Multipath wwids, Version : 1.0
# NOTE: This file is automatically maintained by multipath and multipathd.
# You should not need to edit this file in normal circumstances.
#
# Valid WWIDs:
/149455400000000006c756e31000000000000000000000000/
/149455400000000006c756e32000000000000000000000000/
/149455400000000006c756e30000000000000000000000000/

$ sudo rm /etc/multipath/wwids
$ sudo service multipath-tools restart
$ sudo cat /etc/multipath/wwids
# Multipath wwids, Version : 1.0
# NOTE: This file is automatically maintained by multipath and multipathd.
# You should not need to edit this file in normal circumstances.
#
# Valid WWIDs:

With the proposed fix, the last command would give :
$ sudo cat /etc/multipath/wwids
# Multipath wwids, Version : 1.0
# NOTE: This file is automatically maintained by multipath and multipathd.
# You should not need to edit this file in normal circumstances.
#
# Valid WWIDs:
/149455400000000006c756e31000000000000000000000000/
/149455400000000006c756e32000000000000000000000000/
/149455400000000006c756e30000000000000000000000000/

[Regression]
Only one call to remember_wwid() is added. This is what is currently done in 0.5.0

[Louis Bouchard (louis)]

Marking Yakkety as Invalid since it already has the fix.

[Louis Bouchard (louis)]

Upstream commits :
- http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commit;h=0245b3ac6e34dee1ab039bba71806bc35c286ab8
- http://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commit;h=e7d716fabe85acaaa61ec7065a103ac3a2f16cc2

[Robie Basak (racb)]

@Leonardo

Please do not mess with bug statuses without providing an explanation. The correct status is for the development release Fix Released as Louis reported it fixed in his comment above.

[Brian Murray (brian-murray)]

Hello Louis, or anyone else affected,

Accepted multipath-tools into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/multipath-tools/0.4.9-3ubuntu7.15 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Louis Bouchard (louis)]

Verification done using outlined steps in [Test Case] description

[Launchpad Janitor (janitor)]

This bug was fixed in the package multipath-tools - 0.4.9-3ubuntu7.15

---------------
multipath-tools (0.4.9-3ubuntu7.15) trusty; urgency=medium

  * d/p/0047-Add-existing-multipath-devices-to-wwids-file-on.patch:
    Fix multipathd which does not update /etc/multipath/wwids file
    when reconfigure is invoked. (LP: #1621835)

  [ Dragan Stancevic ]
  * d/p/0048-multipathd-delay-free-pathvec.patch :
    Fix SEGV on multipathd shutdown (LP: #1616213)

  [ Nishanth Aravamudan ]
  * debian/patches/fix_use_after_free.patch: Fix use-after-free bugs.
    Thanks to Christof Schmitt <email address hidden> and
    Benjamin Marzinski <email address hidden>. Closes LP: #1628723.

 -- Louis Bouchard <email address hidden> Mon, 12 Sep 2016 10:43:19 +0200

[Chris J Arges (arges)]

The verification of the Stable Release Update for multipath-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.