Error message showing up when tried to share among the users

[Niranjan]

Version master 16.10
Happens in PHP server

Encountered the following error message:

[WAR] fb (view/access.php:415) Undefined index: startdate
Call stack (most recent first):

    log_message("Undefined index: startdate", 8, true, true, "/home/niranjanbandi/code/mahara/htdocs/view/access...", 415) at /home/niranjanbandi/code/mahara/htdocs/lib/errors.php:513
    error(8, "Undefined index: startdate", "/home/niranjanbandi/code/mahara/htdocs/view/access...", 415, array(size 10)) at /home/niranjanbandi/code/mahara/htdocs/view/access.php:415
    editaccess_validate(object(Pieform), array(size 11)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:1449
    Pieform->validate(array(size 11)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:521
    Pieform->__construct(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/pieforms/pieform.php:164
    Pieform::process(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/lib/mahara.php:4728
    pieform(array(size 8)) at /home/niranjanbandi/code/mahara/htdocs/view/access.php:555

Steps to reproduce:

1) Login as a admin user or normal user

2) Navigate to portfolio>Shared by me ( make sure you have a profile page in it )

3)Click on Edit Access ( key icon)

4)select share with users and select one user. Make sure you don't enter from and to dates in it

5)Click on save

Result: Php code is displayed with some warning message.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6956

[Niranjan (niranjan528)]

Tested it on 16.04 and 16.10 on all the possible browsers. Bug fixed and its a pass:)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6956
Committed: https://git.mahara.org/mahara/mahara/commit/e3510c9ef3a4aff0c08e619a6dea6b47ac2d4000
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit e3510c9ef3a4aff0c08e619a6dea6b47ac2d4000
Author: Robert Lyon <email address hidden>
Date: Mon Sep 12 14:29:45 2016 +1200

Bug 1620411: Fixing up the checking for start/stop dates

When the row has disabled fields

Also fixing select options when we have a locked option

We used to remove the option but this causes a problem showing the
option as selected one. Need to keep all options and then disable the
locked one from being picked twice.

behatnotneeded

Change-Id: I4db0d6810099c751f46b504edf1a0cffde6e6b83
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7029

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7029
Committed: https://git.mahara.org/mahara/mahara/commit/27b8530a01b70cb5d3132977d83a7f4e417b2dbe
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 27b8530a01b70cb5d3132977d83a7f4e417b2dbe
Author: Robert Lyon <email address hidden>
Date: Mon Sep 12 14:29:45 2016 +1200

Bug 1620411: Fixing up the checking for start/stop dates

When the row has disabled fields

Also fixing select options when we have a locked option

We used to remove the option but this causes a problem showing the
option as selected one. Need to keep all options and then disable the
locked one from being picked twice.

behatnotneeded

Change-Id: I4db0d6810099c751f46b504edf1a0cffde6e6b83
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e3510c9ef3a4aff0c08e619a6dea6b47ac2d4000)