A typo in Horizon and source code in docs.o.o/developer/horizon

[Ian Y. Choi]

In http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/floating_ips/views.py#n119 ,

Line 119, "msg = _('Unknow resource type for detail API.')"
: "Unknow" is typo. It should be changed to "Unknown".

I am not sure whether the source code in following developer documentation page automatically links to the original source code or not. If not, please consider it.

In http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html ,

" msg = _('Unknow resource type for detail API.') "

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/365264

[tamil vanan (tamilhce)]

Hi Ian,

Regarding the bug 1619847,
As per my understanding we can't change http://docs.openstack.org/
developer/horizon/_modules/openstack_dashboard/
dashboards/admin/floating_ips/views.html directly.

The fix in
 http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/
dashboards/admin/floating_ips/views.py#n119

will change the http://docs.openstack.org/developer/horizon/_modules/
openstack_dashboard/dashboards/admin/floating_ips/views.html accordingly.

Regards,
Tamil

  ,

On Sun, Sep 4, 2016 at 12:28 PM, Ian Y. Choi <email address hidden> wrote:

> ** Summary changed:
>
> - A typo in Horizon and source code in developer.o.o doc
> + A typo in Horizon and source code in docs.o.o
>
> ** Summary changed:
>
> - A typo in Horizon and source code in docs.o.o
> + A typo in Horizon and source code in docs.o.o/developer/horizon
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1619847
>
> Title:
> A typo in Horizon and source code in docs.o.o/developer/horizon
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
>
> Bug description:
> In
> http://git.openstack.org/cgit/openstack/horizon/tree/
> openstack_dashboard/dashboards/admin/floating_ips/views.py#n119
> ,
>
> Line 119, "msg = _('Unknow resource type for detail API.')"
> : "Unknow" is typo. It should be changed to "Unknown".
>
> I am not sure whether the source code in following developer
> documentation page automatically links to the original source code or
> not. If not, please consider it.
>
> In
> http://docs.openstack.org/developer/horizon/_modules/
> openstack_dashboard/dashboards/admin/floating_ips/views.html
> ,
>
> " msg = _('Unknow resource type for detail API.') "
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1619847/+subscriptions
>

[Ian Y. Choi (ianychoi)]

Hello Tamil,

I think your saying is correct. Thanks for letting me know this.

Just I have noticed that the summary in Launchpad because the document
URL is docs.o.o/developer, not developer.o.o.
That's why I have changed the summary title :)

With many thanks,

/Ian

tamil vanan wrote on 9/4/2016 4:26 PM:
> Hi Ian,
>
> Regarding the bug 1619847,
> As per my understanding we can't change
> http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html
> <http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html>
> directly.
>
> The fix in
> http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/floating_ips/views.py#n119
> <http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/floating_ips/views.py#n119>
>
> will change the
> http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html
> <http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html>
> accordingly.
>
> Regards,
> Tamil
>
> ,
>
> On Sun, Sep 4, 2016 at 12:28 PM, Ian Y. Choi <<email address hidden>
> <mailto:<email address hidden>>> wrote:
>
> ** Summary changed:
>
> - A typo in Horizon and source code in developer.o.o doc
> + A typo in Horizon and source code in docs.o.o
>
> ** Summary changed:
>
> - A typo in Horizon and source code in docs.o.o
> + A typo in Horizon and source code in docs.o.o/developer/horizon
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1619847
> <https://bugs.launchpad.net/bugs/1619847>
>
> Title:
> A typo in Horizon and source code in docs.o.o/developer/horizon
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
>
> Bug description:
> In
> http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/floating_ips/views.py#n119
> <http://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/admin/floating_ips/views.py#n119>
> ,
>
> Line 119, "msg = _('Unknow resource type for detail API.')"
> : "Unknow" is typo. It should be changed to "Unknown".
>
> I am not sure whether the source code in following developer
> documentation page automatically links to the original source
> code or
> not. If not, please consider it.
>
> In
> http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html
> <http://docs.openstack.org/developer/horizon/_modules/openstack_dashboard/dashboards/admin/floating_ips/views.html>
> ,
>
> " msg = _('Unknow resource type for detail API.') "
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1619847/+subscriptions
> <https://bugs.launchpad.net/horizon/+bug/1619847/+subscriptions>
>
>

[tamil vanan (tamilhce)]

Regarding the bug 1619847,
As per my understanding we can't change http://docs.
openstack.org/developer/horizon/_modules/openstack_
dashboard/dashboards/admin/floating_ips/views.html directly.

The fix in
 http://git.openstack.org/cgit/openstack/horizon/tree/op
enstack_dashboard/dashboards/admin/floating_ips/views.py#n119

will change the http://docs.openstack.org/de
veloper/horizon/_modules/openstack_dashboard/dashboards/
admin/floating_ips/views.html accordingly.

Regards,
Tamil

On Mon, Sep 5, 2016 at 2:40 PM, Rob Cresswell <email address hidden> wrote:

> ** Changed in: horizon
> Milestone: None => newton-rc1
>
> ** Changed in: horizon
> Importance: Undecided => Low
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1619847
>
> Title:
> A typo in Horizon and source code in docs.o.o/developer/horizon
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
>
> Bug description:
> In
> http://git.openstack.org/cgit/openstack/horizon/tree/
> openstack_dashboard/dashboards/admin/floating_ips/views.py#n119
> ,
>
> Line 119, "msg = _('Unknow resource type for detail API.')"
> : "Unknow" is typo. It should be changed to "Unknown".
>
> I am not sure whether the source code in following developer
> documentation page automatically links to the original source code or
> not. If not, please consider it.
>
> In
> http://docs.openstack.org/developer/horizon/_modules/
> openstack_dashboard/dashboards/admin/floating_ips/views.html
> ,
>
> " msg = _('Unknow resource type for detail API.') "
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1619847/+subscriptions
>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/365264
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ed3a382dee6806bac375861d272fc6499ca72b79
Submitter: Jenkins
Branch: master

commit ed3a382dee6806bac375861d272fc6499ca72b79
Author: tamilhce <email address hidden>
Date: Sat Sep 3 15:33:45 2016 +0000

    Fix for typo in Horizon

    The horizon views.py had a typo in error msg
    Closes-Bug: #1619847

    Change-Id: I5d41cb3318ca7a54ec973404cb03afdc3453c021

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.