patch - fix Caja crash on unchecking "Show hidden and backup files" in prefs dialog

[Vlad Orlov]

[Impact]

Due to a bug in Caja code, users see it crashing when they uncheck the "Show hidden and backup files" in the prefs dialog. It had been fixed in version 1.14.1, but it would be nice to backport it as a patch for 1.12, which is the default version in Ubuntu MATE 16.04 (if not using the PPA).

Patch is provided in the attachment below.

[Test Case]

0. Have Ubuntu MATE 16.04 with MATE 1.12 (no xenial-mate PPA enabled).
1. Open Caja prefs dialog.
2. If "Show hidden and backup files" isn't checked, check it, then close the dialog and then open it again. That's because the item should be checked first in order to trigger the bug.
3. Now uncheck "Show hidden and backup files".
4. Caja crashes.

[Regression Potential]

During several months of testing the fix in 1.14, I haven't found any regressions. The fix does affect quite small part of code, so regression potential in regards to the whole functionality of Caja should be very low.

[Other Info]

Source of patch: https://github.com/mate-desktop/caja/commit/9a86c2cbc0b1e75f9073461ead8bc2d917694921
Upstream bug report: https://github.com/mate-desktop/caja/issues/326
Debian bug report: https://bugs.debian.org/797723

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "fix-hidden-files-crash.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Simon Quigley (tsimonq2)]

Uploaded.

[Łukasz Zemczak (sil2100)]

Hello Vlad, or anyone else affected,

Accepted caja into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/caja/1.12.7-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Vlad Orlov (monsta)]

Testing...

- replaced my locally built caja, caja-common, gir1.2-caja, libcaja-extension-dev, libcaja-extension1 packages with 1.12.7-1ubuntu0.1 from xenial-proposed
- restarted Caja
- opened Caja's prefs dialog
- unchecked "Show hidden and backup files"

Ok, Caja doesn't crash. Just in case, I toggled "Show hidden and backup files" several times more (open the prefs dialog - toggle the checkmark - close the dialog). All good, no crashes.

[Launchpad Janitor (janitor)]

This bug was fixed in the package caja - 1.12.7-1ubuntu0.1

---------------
caja (1.12.7-1ubuntu0.1) xenial; urgency=medium

  * fix-hidden-files-crash.patch: new patch. Fixes crash on toggling
    "Show hidden and backup files" in prefs dialog (LP: #1619654)

 -- Vlad Orlov <email address hidden> Mon, 30 Oct 2017 16:02:30 +0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for caja has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.