Profile completion annotation feedback doesn't count down

[Cecilia Vela Gurovic]

This is a follow on to bug #1596809. The annotation feedback count does not go down when the user places feedback on annotations.

To replicate:

1. Turn on the "Annotation" block
2. Set up profile completion for an institution
3. Make sure that at least 3 annotation feedbacks are required for the profile completion.
4. Go to Configure site -> User settings -> Turn on profile completion.
5. Take a look at the block on UserA's dashboard. The user needs to be a member of the institution in which the profile completion has been turned on.
6. Log in as UserB, create a page and place an annotation block on that page.
7. Share the page with UserA.
8. Log in as UserA and add feedback on the annotation block on the page of UserB.
9.
Expected behavior: When UserA goes to the Profile completion block on her dashboard, she should see "Give 2 feedbacks on annotations" as she already placed a feedback.
Actual behavior: When UserA goes to the Profile completion block, she still sees "Give 3 feedbacks on annotations".

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6943

[Robert Lyon (robertl-9)]

The problem here is the annotation progress completion code was copied from 'comments' plugin but annotations is more complex.

So what we need is two options for annotations.

1) to count all the annotation blocks a user has added to their pages
2) to count all the feedbacks on annotations a user has done for other users annotations

I'll add a patch that deals with these options for a start.

Maybe there should be an options relating to SmartEvidence as well?

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6943
Committed: https://git.mahara.org/mahara/mahara/commit/cf5844d2c04639f907b0766fe9f3f619e46c80e0
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit cf5844d2c04639f907b0766fe9f3f619e46c80e0
Author: Robert Lyon <email address hidden>
Date: Wed Sep 7 19:26:56 2016 +1200

Bug 1619514: Fixing up annotation progress

Made it have two options now:
1) 'annotation' - Counts the number of annotations a user has added
to their pages.
2) 'annotationfeedback' - Counts the number of feedbacks left on
annotations owned by other users

behatnotneeded

Change-Id: Id3ccec9f104c861ce3fe9ed46cf1fcfe92b5d0bb
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/6954

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6954
Committed: https://git.mahara.org/mahara/mahara/commit/6c09a34985ccab18491719233c0abbed7d3dccb3
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 6c09a34985ccab18491719233c0abbed7d3dccb3
Author: Robert Lyon <email address hidden>
Date: Wed Sep 7 19:26:56 2016 +1200

Bug 1619514: Fixing up annotation progress

Made it have two options now:
1) 'annotation' - Counts the number of annotations a user has added
to their pages.
2) 'annotationfeedback' - Counts the number of feedbacks left on
annotations owned by other users

behatnotneeded

Change-Id: Id3ccec9f104c861ce3fe9ed46cf1fcfe92b5d0bb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit cf5844d2c04639f907b0766fe9f3f619e46c80e0)