Refactor tests in tripleoclient
Bug #1619350 reported by
Dougal Matthews
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Medium
|
Kamil Sambor |
Bug Description
At the moment tripleoclient uses tons (and tons and tons) of mocks. These were originally used as the quickest way to get started but have become unmaintainable.
At the current count, there are 158 mock.patch calls in test_overcloud_
New tests when added typically copy others and thus add many more mocks. It would be much better to have fakes for the services that we currently mock. This would mean that they are updated in a central place and would remove some of the duplication and over mocking.
description: | updated |
Changed in tripleo: | |
milestone: | none → queens-1 |
Changed in tripleo: | |
milestone: | queens-1 → queens-2 |
Changed in tripleo: | |
milestone: | queens-2 → queens-3 |
Changed in tripleo: | |
milestone: | queens-3 → queens-rc1 |
Changed in tripleo: | |
milestone: | queens-rc1 → rocky-1 |
Changed in tripleo: | |
milestone: | rocky-1 → rocky-2 |
Changed in tripleo: | |
milestone: | rocky-2 → rocky-3 |
Changed in tripleo: | |
assignee: | nobody → Kamil Sambor (ksambor) |
status: | Triaged → In Progress |
Changed in tripleo: | |
milestone: | rocky-3 → stein-1 |
tags: | added: tech-debt |
Changed in tripleo: | |
assignee: | Kamil Sambor (ksambor) → Dougal Matthews (d0ugal) |
Changed in tripleo: | |
assignee: | Dougal Matthews (d0ugal) → Kamil Sambor (ksambor) |
To post a comment you must log in.
Fix proposed to branch: master /review. openstack. org/364388
Review: https:/