Activity log for bug #1619350

Date Who What changed Old value New value Message
2016-09-01 15:22:53 Dougal Matthews bug added bug
2016-09-01 15:25:31 Dougal Matthews description At the moment tripleoclient uses tons (and tons and tons) of mocks. These were originally used as the quickest way to get started but have become unmaintainable. At the current count, there are 158 mock.patch calls in test_overcloud_deploy. New tests when added typically copy others and thus add many more mocks. It would be much better to have a test double or a fake for the services that we currently mock. This would mean that they are updated in a central place and would remove some of the duplication and over mocking. At the moment tripleoclient uses tons (and tons and tons) of mocks. These were originally used as the quickest way to get started but have become unmaintainable. At the current count, there are 158 mock.patch calls in test_overcloud_deploy. New tests when added typically copy others and thus add many more mocks. It would be much better to have fakes for the services that we currently mock. This would mean that they are updated in a central place and would remove some of the duplication and over mocking.
2016-09-01 15:31:00 OpenStack Infra tripleo: status Confirmed In Progress
2016-09-01 15:31:00 OpenStack Infra tripleo: assignee Steven Hardy (shardy)
2017-07-05 18:55:38 Emilien Macchi tripleo: status In Progress Confirmed
2017-07-05 18:55:40 Emilien Macchi tripleo: assignee Steven Hardy (shardy)
2017-08-30 12:27:27 Ryan Brady tripleo: status Confirmed Fix Released
2017-09-08 10:47:16 Julie Pichon tripleo: status Fix Released Triaged
2017-09-08 11:10:16 Dougal Matthews tripleo: milestone queens-1
2017-10-04 20:21:31 Alex Schultz tripleo: milestone queens-1 queens-2
2017-11-02 21:05:50 Alex Schultz tripleo: milestone queens-2 queens-3
2018-01-26 01:12:20 Emilien Macchi tripleo: milestone queens-3 queens-rc1
2018-02-20 22:23:30 Alex Schultz tripleo: milestone queens-rc1 rocky-1
2018-04-20 17:56:00 Alex Schultz tripleo: milestone rocky-1 rocky-2
2018-06-05 19:53:23 Emilien Macchi tripleo: milestone rocky-2 rocky-3
2018-06-19 05:53:02 Kamil Sambor tripleo: assignee Kamil Sambor (ksambor)
2018-06-19 05:53:16 Kamil Sambor tripleo: status Triaged In Progress
2018-06-29 09:06:07 Bogdan Dobrelya tripleo: milestone rocky-3 stein-1
2018-06-29 09:06:13 Bogdan Dobrelya tags tripleoclient tech-debt tripleoclient
2018-08-14 10:12:41 OpenStack Infra tripleo: assignee Kamil Sambor (ksambor) Dougal Matthews (d0ugal)
2018-08-14 10:27:10 Kamil Sambor tripleo: assignee Dougal Matthews (d0ugal) Kamil Sambor (ksambor)
2018-10-20 07:54:48 OpenStack Infra tripleo: status In Progress Fix Released