Port gufw to WebKit2

[Jeremy Bícha]

The old webkitgtk api is no longer being developed and it likely has security issues fixed in the new webkit2gtk. From what I can tell, gufw is the last thing keeping the old webkitgtk on Ubuntu MATE's yakkety image.

https://blogs.gnome.org/mcatanzaro/2016/03/30/positive-progress-on-webkitgtk-security-updates/

I'm attaching a patch to convert gufw to WebKit2. I just made up the arguments for context_menu_cb; it needed 5 of them...

https://lazka.github.io/pgi-docs/WebKit2-4.0/classes/WebView.html#WebKit2.WebView.signals.context_menu

You'll also want to change gir1.2-webkit-3.0 to gir1.2-webkit2-4.0 in
your debian/control.

[costales (costales)]

Thanks a lot for the patch Jeremy!!!
I have to migrate to Python3 too. Can I ask for your help if I have problems?
A hug
--
Sent using Dekko from my Ubuntu device

[Jeremy Bícha (jbicha)]

Porting from Python2 to Python3 should be relatively easy now.

I'd like to get the WebKit2 conversion in for Ubuntu 16.10.

[costales (costales)]

Hi Jeremy,

I think is done :)

One question about python3 migration please, do you know why Gufw is stored in python2?

costales@costales-VirtualBox:~/Desktop/gui-ufw$ sudo python setup.py install --prefix=/usr

[...]

costales@costales-VirtualBox:~/Desktop/gui-ufw$ find /usr/lib -name "gufw.py"
/usr/lib/python2.7/site-packages/gufw/gufw.py
/usr/lib/python2.7/site-packages/gufw/view/gufw.py
costales@costales-VirtualBox:~/Desktop/gui-ufw$

Thanks in advance!

[Jeremy Bícha (jbicha)]

I believe you want to run python3 not python in the command you posted.

You could also use the Debian packaging to install gufw. Here's a mostly untested patch to update the packaging to python3.

[costales (costales)]

Hi Jeremy!

I'm a bit stuck with the not relative imports of python3 grrrrr :P Do
you know where is the issue?
Gufw appears install right and run now with python3 (I have to check
everything yet) but I'm having these 2 first warning + error when I
try to install with:

costales@dev:~/Desktop/gui-ufw$ sudo python3 setup.py install --prefix=/usr
/usr/lib/python3/dist-packages/DistUtilsExtra/auto.py:349:
PyGIWarning: Gdk was imported without specifying a version first. Use
gi.require_version('Gdk', '3.0') before import to ensure that the
right version gets loaded.
  mod = __import__(module)
ERROR: Python module controller not found
[.... everything OK from here ...]

Thanks in advance!
--
Sent using Dekko from my Ubuntu device

[Jeremy Bícha (jbicha)]

Sorry, I haven't done any python2>python3 conversions lately. You could try asking the Debian Python teams: https://wiki.debian.org/Teams/PythonAppsPackagingTeam

[costales (costales)]

Hi Jeremy,

I asked now for the upload :)
https://lists.launchpad.net/gufw-maintainers/msg00021.html

Thanks a lot for your patch! I own you a few beers :)
A hug!
--
Sent using Dekko from my Ubuntu device

On Wed, Aug 31, 2016 at 11:52 PM, Jeremy Bicha <email address hidden> wrote:
> Sorry, I haven't done any python2>python3 conversions lately. You could
> try asking the Debian Python teams:
> https://wiki.debian.org/Teams/PythonAppsPackagingTeam
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1617780
>
> Title:
> Port gufw to WebKit2
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/gui-ufw/+bug/1617780/+subscriptions

[Jeremy Bícha (jbicha)]

https://launchpad.net/ubuntu/+source/gui-ufw/16.10.0-1

[costales (costales)]

HI Jeremy :) Then did you upload it?? Thanks a lot mate!!

--
--
Sent using Dekko from my Ubuntu device

[Jeremy Bícha (jbicha)]

Yes, but Devid did the packaging work!

[Jeremy Bícha (jbicha)]

He uploaded it to Debian too.

https://tracker.debian.org/pkg/gui-ufw