Pause/Resume doesn't work right in Sudoku (needs redraw)

[Jeremy Bícha]

Impact
======
Clicking the Pause button doesn't hide the current game like it should, unless you force a redraw by minimizing the window or switching to a different window, etc.

Similarly, clicking Resume doesn't unhide the current game unless you do the same thing.

Test Case
=========
1. Install the update
2. Run Sudoku. Click Easy. Click Pause.
3. The game play area should be greyed out with a "Paused" text overlay
4. Click Resume. The game play area should return to normal.

To test the other major fix:
1. Click New Puzzle, then select Very Hard.
2. Does the puzzle appear to match the first puzzle listed at https://bugzilla.gnome.org/768345 ? (The puzzle should be completely different.)
3. Make a screenshot or otherwise record what that first Very Hard puzzle looks like.
4. Exit Sudoku.
5. Reopen Sudoku and start a new Very Hard puzzle.
6. The puzzle should be different than the first Very Hard puzzle (from steps 1-3).

Regression Potential
====================
The Pause/Resume fix is a one-line fix to redraw the screen when the pause state is changed. The fix was released yesterday as gnome-sudoku 3.18.4 and 3.20.5.

3.18.3 was released a few weeks ago with the fix for random puzzle generation

https://git.gnome.org/browse/gnome-sudoku/log/?h=gnome-3-18
https://git.gnome.org/browse/gnome-sudoku/tree/NEWS?h=gnome-3-18

The only other changes are translation updates.

These fixes have all been incorporated into yakkety's gnome-sudoku 1:3.21.90-0ubuntu2.

ProblemType: Bug
DistroRelease: Ubuntu 16.10
Package: gnome-sudoku 1:3.21.90-0ubuntu1
ProcVersionSignature: Ubuntu 4.6.0-10.12-generic 4.6.5
Uname: Linux 4.6.0-10-generic x86_64
ApportVersion: 2.20.3-0ubuntu7
Architecture: amd64
CurrentDesktop: GNOME
Date: Sat Aug 20 12:40:13 2016
EcryptfsInUse: Yes
InstallationDate: Installed on 2016-08-11 (8 days ago)
InstallationMedia: Ubuntu-GNOME 16.10 "Yakkety Yak" - Alpha amd64 (20160811)
SourcePackage: gnome-sudoku
UpgradeStatus: No upgrade log present (probably fresh install)

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-sudoku - 1:3.21.90-0ubuntu2

---------------
gnome-sudoku (1:3.21.90-0ubuntu2) yakkety; urgency=medium

  * git_fix-pause.patch:
    - Redraw the screen when Pause or Resume are selected (LP: #1615252)

 -- Jeremy Bicha <email address hidden> Sat, 20 Aug 2016 13:26:40 -0400

[Martin Pitt (pitti)]

Hello Jeremy, or anyone else affected,

Accepted gnome-sudoku into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-sudoku/1:3.18.4-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jeremy Bícha (jbicha)]

pitti, could you upload gnome-sudoku 1:3.18.4-0ubuntu2? It fixes the FTBFS in -0ubuntu1.

[Jeremy Bícha (jbicha)]

I mean "approve" not "upload"

[Jeremy Bícha (jbicha)]

I already made the change in yakkety to remove the vala stamp files:
https://launchpad.net/ubuntu/+source/gnome-sudoku/1:3.21.90-0ubuntu1

[Martin Pitt (pitti)]

Accepted, thanks!

[Jeremy Bícha (jbicha)]

I tested the proposed update in Ubuntu GNOME 16.04. I confirm that Pause and Resume now works correctly. I can also confirm that the Very Hard puzzles now appear to be randomly generated.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-sudoku - 1:3.18.4-0ubuntu2

---------------
gnome-sudoku (1:3.18.4-0ubuntu2) xenial; urgency=medium

  * debian/rules:
    - Delete vala stamps to rebuild generated source files. This
      fixes 3.18.4's failure to build from source in Ubuntu 16.04.

gnome-sudoku (1:3.18.4-0ubuntu1) xenial; urgency=medium

  * New upstream bugfix release (LP: #1615252)
    - Make 'Pause' correctly hide the game play area and 'Resume'
      show it again
    - Fix the random puzzle generator so new puzzles don't follow
      the same exact sequence.

 -- Jeremy Bicha <email address hidden> Thu, 25 Aug 2016 01:11:18 -0400

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for gnome-sudoku has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.