php-xml dependency missing in 16.04

[Peter Faymonville]

[Impact]

As indicated here: http://wiki.davical.org/index.php/DAViCal_Dependencies ,
the package davical is missing the dependency php-xml and thus some HTTP requests fail with error 500.

[Test case]

curl --request PROPFIND --user ds:xxx --header "Content-Type: text/xml" --header "Brief:t" --data "<D:propfind xmlns:D="DAV:"><D:prop><D:displayname/></D:prop></D:propfind>" http://localhost/davical/caldav.php/ds/addresses/

Should not result in 'Call to undefined function xml_parser_create_ns()'

See https://gitlab.com/davical-project/davical/issues/91

[Regression Potential]

It's just an added dependency. At worst, it would install a useless package.

[Florian Schlichting (fschlich)]

in Debian, this was fixed in 1.1.4-3, which by now has migrated to yakkety, but not xenial (where it arguably would be needed most):

https://gitlab.com/davical-project/davical/commit/482850e6b21bafd3aea0c102edff18be11dc6293

From 482850e6b21bafd3aea0c102edff18be11dc6293 Mon Sep 17 00:00:00 2001
From: Florian Schlichting <email address hidden>
Date: Wed, 1 Jun 2016 22:20:00 +0200
Subject: [PATCH] Add missing dependency on php-xml, which is a separate package from PHP 7 (fixes #91)

---
 debian/changelog | 6 ++++++
 debian/control | 1 +
 2 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index f87ceb7..5c19c09 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+davical (1.1.4-3) unstable; urgency=medium
+
+ * Add missing dependency on php-xml, which is a separate package from PHP 7
+
+ -- Florian Schlichting <email address hidden> Wed, 01 Jun 2016 22:18:51 +0200
+
 davical (1.1.4-2) unstable; urgency=medium

   * Update to work with both php5 and php7, mainly based on the Ubuntu patch
diff --git a/debian/control b/debian/control
index ceb928e..9cfb474 100644
--- a/debian/control
+++ b/debian/control
@@ -23,6 +23,7 @@ Depends: ${misc:Depends}, ${perl:Depends},
  php | php5,
  php-cli | php5-cli,
  php-pgsql | php5-pgsql,
+ php-xml | php5,
  postgresql-client
 Recommends: php-curl | php5-curl,
  postgresql
--
libgit2 0.24.0

[Florian Schlichting (fschlich)]

See this upstream issue on how to actually test the problem on a running davical server: https://gitlab.com/davical-project/davical/issues/91

From the error message "Call to undefined function xml_parser_create_ns()" it is obvious that the PHP XML module is missing (c.f. http://de2.php.net/manual/en/function.xml-parser-create-ns.php)

[Florian Schlichting (fschlich)]

Patch adjusted to the davical version in xenial:

diff --git a/debian/changelog b/debian/changelog
index 23afa22..b7df2e6 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+davical (1.1.4-1ubuntu2) xenial; urgency=medium
+
+ * Add missing dependency on php-xml (LP: #1610704)
+
+ -- Florian Schlichting <email address hidden> Mon, 19 Sep 2016 13:02:40 +0200
+
 davical (1.1.4-1ubuntu1) xenial; urgency=medium

   * Update to PHP7.0 dependencies (LP: #1544352).
diff --git a/debian/control b/debian/control
index 7a727a6..d43520f 100644
--- a/debian/control
+++ b/debian/control
@@ -24,6 +24,7 @@ Depends: ${misc:Depends}, ${perl:Depends},
  php,
  php-cli,
  php-pgsql,
+ php-xml,
  postgresql-client
 Recommends: php-curl,
  postgresql

[Marc Deslauriers (mdeslaur)]

ACK on the debdiff in comment #3, thanks!

I've uploaded it for processing by the SRU team with a slight version change.

[Chris J Arges (arges)]

Hello Peter, or anyone else affected,

Accepted davical into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/davical/1.1.4-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Peter Faymonville (peter-faymonville)]

Hello Chris, hello Florian,

I just tested the fix under xenial with version davical_1.1.4-1ubuntu1.1 and the problem is solved.

Thanks to everyone,

Peter

[Launchpad Janitor (janitor)]

This bug was fixed in the package davical - 1.1.4-1ubuntu1.1

---------------
davical (1.1.4-1ubuntu1.1) xenial; urgency=medium

  * Add missing dependency on php-xml (LP: #1610704)

 -- Florian Schlichting <email address hidden> Mon, 19 Sep 2016 13:02:40 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for davical has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.