Page themes don't work with configurable theme
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Master mahara (but also on 16.04 and 15.10)
When users can choose a theme for their pages and the institution uses the configurable theme, nothing is being displayed properly.
Part of the configurable theme is always visible but the acutal chosen theme is used for the navigation, which does not look good. And then putting skins on top...
To replicate the issue:
1. Allow users to choose page themes: Admin -> Configure site -> User settings -> Users can choose page themes.
2. Create an institution and choose the configurable theme. Choose a dark background color so that header nav items need to be white.
3. Add a user to that institution.
4. Set up a page as that user and give it a different theme.
Expected result: The theme overwrites the configurable theme completely like it does when a an institution has a regular theme.
Actual result: Part of the configurable theme is still visible (see screenshot).
The screenshot also shows how it would look like with a skin. The skin doesn't influence it badly though. Just something to keep in mind for testing.
Changed in mahara: | |
milestone: | 16.10.0 → 16.10.1 |
Changed in mahara: | |
milestone: | 16.10.1 → 17.04.0 |
Changed in mahara: | |
status: | Confirmed → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
By the looks of things, the theme is loaded first but then the configurable theme is loaded after that. We will most likely need to change that order in the code.