[SRU] Syntax error 'type' in neutron-linuxbridge-cleanup.service

[Paul Seidler]

[Impact]

 * neutron-linuxbridge-cleanup service start warning message

[Test Case]

 * Execute the following on Xenial (Mitaka):
    - sudo systemctl start neutron-linuxbridge-cleanup
    - sudo systemctl status neutron-linuxbridge-cleanup| grep "Unknown lvalue 'type' in section 'Service'"

[Regression Potential]

 * None

The service file /lib/systemd/system/neutron-linuxbridge-cleanup.service contains a syntax error.

It contains a type on line 5: "type=oneshot"
But it should be: "Type=oneshot"

1)
Version information:
neutron-linuxbridge-agent:
  Installed: 2:8.1.2-0ubuntu1
  Candidate: 2:8.1.2-0ubuntu1
  Version table:
 *** 2:8.1.2-0ubuntu1 500
        500 http://de.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
        500 http://de.archive.ubuntu.com/ubuntu xenial-updates/main i386 Packages
        500 http://security.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
        500 http://security.ubuntu.com/ubuntu xenial-updates/main i386 Packages
        100 /var/lib/dpkg/status
     2:8.0.0-0ubuntu1 500
        500 http://de.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
        500 http://de.archive.ubuntu.com/ubuntu xenial/main i386 Packages
        500 http://security.ubuntu.com/ubuntu xenial/main amd64 Packages
        500 http://security.ubuntu.com/ubuntu xenial/main i386 Packages

2)
lsb:
Description: Ubuntu 16.04 LTS
Release: 16.04

3)
Service should start successfull on service start

4)
systemd[1]: [/lib/systemd/system/neutron-linuxbridge-cleanup.service:5] Unknown lvalue 'type' in section 'Service'

[Corey Bryant (corey.bryant)]

Hi Paul, Thanks for reporting this. I've committed the fix and it is targeted to release with the Newton b3 release, if not sooner.

[Launchpad Janitor (janitor)]

This bug was fixed in the package neutron - 2:9.0.0~b3-0ubuntu2

---------------
neutron (2:9.0.0~b3-0ubuntu2) yakkety; urgency=medium

  * d/control: Set minimum version of neutron-fwaas to 9.0.0~b3, resolving
    autopkgtest failures during db migrations.

 -- James Page <email address hidden> Mon, 05 Sep 2016 10:51:56 +0100

[Paul Seidler (paul-seidler)]

Thanks for the fix!

Could we please backport this one to xenial?

[Corey Bryant (corey.bryant)]

Hi Paul, this is also available in the newton cloud archive on xenial.

[Paul Seidler (paul-seidler)]

Hi Corey, let me be more precise: Could we see this fix in xenial-updates repository please?

My initial bug report was against version 8 of neutron which is Mitaka. Should I create a new bug report?

[Corey Bryant (corey.bryant)]

Ed, Thanks for the patch.

We didn't fix the typo in neutron-openvswitch-agent.neutron-ovs-cleanup.service.in yet and now that this bug is fix released for newton+ we need to track that bit in another bug. I've opened the following bug to track the typo in neutron-ovs-cleanup:

https://bugs.launchpad.net/cloud-archive/+bug/1635369

[Corey Bryant (corey.bryant)]

Ed I'll update the bug # in your patch. Thanks.

[Michael Hudson-Doyle (mwhudson)]

This seems to be in progress, so I'm unsubscribing ~ubuntu-sponsors. Feel free to resubscribe if I've misunderstood :)

[Martin Pitt (pitti)]

Hello Paul, or anyone else affected,

Accepted neutron into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/neutron/2:8.3.0-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Edward Hope-Morley (hopem)]

Testing with Mitaka and xenial-proposed and lgtm.

[James Page (james-page)]

Hello Paul, or anyone else affected,

Accepted neutron into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository.

Please help us by testing this new package. To enable the -proposed repository:

  sudo add-apt-repository cloud-archive:mitaka-proposed
  sudo apt-get update

Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-mitaka-needed to verification-mitaka-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-mitaka-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package neutron - 2:8.3.0-0ubuntu1.1

---------------
neutron (2:8.3.0-0ubuntu1.1) xenial; urgency=medium

  * Fix service config typo:
    - debian/neutron-openvswitch-agent.neutron-ovs-cleanup.service.in (LP: #1635369).
    - debian/neutron-linuxbridge-agent.neutron-linuxbridge-cleanup.service.in (LP: #1606652).

 -- Edward Hope-Morley <email address hidden> Thu, 20 Oct 2016 17:24:10 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Ryan Beisner (1chb1n)]

The verification of the Stable Release Update for neutron has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Ryan Beisner (1chb1n)]

This bug was fixed in the package neutron - 2:8.3.0-0ubuntu1.1~cloud0
---------------

 neutron (2:8.3.0-0ubuntu1.1~cloud0) trusty-mitaka; urgency=medium
 .
   * New update for the Ubuntu Cloud Archive.
 .
 neutron (2:8.3.0-0ubuntu1.1) xenial; urgency=medium
 .
   * Fix service config typo:
     - debian/neutron-openvswitch-agent.neutron-ovs-cleanup.service.in (LP: #1635369).
     - debian/neutron-linuxbridge-agent.neutron-linuxbridge-cleanup.service.in (LP: #1606652).