tp-smapi-dkms 0.41-1: tp-smapi kernel module failed to build [error: return from incompatible pointer type]

[i2000s]

Seems it's not supporting kernel 4.7.0 yet. Hopefully some day, everything will work smoothly.

Thanks!

ProblemType: Package
DistroRelease: Ubuntu 16.04
Package: tp-smapi-dkms 0.41-1
Uname: Linux 4.7.0-040700-generic x86_64
NonfreeKernelModules: nvidia_uvm nvidia_drm nvidia_modeset nvidia
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64
DKMSKernelVersion: 4.7.0-040700-generic
Date: Tue Jul 26 00:11:40 2016
DuplicateSignature: dkms:tp-smapi-dkms:0.41-1:include/linux/moduleparam.h:344:67: error: return from incompatible pointer type [-Werror=incompatible-pointer-types]
InstallationDate: Installed on 2016-04-26 (90 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1)
PackageArchitecture: all
PackageVersion: 0.41-1
RelatedPackageVersions:
 dpkg 1.18.4ubuntu1.1
 apt 1.2.12~ubuntu16.04.1
SourcePackage: tp-smapi
Title: tp-smapi-dkms 0.41-1: tp-smapi kernel module failed to build
UpgradeStatus: No upgrade log present (probably fresh install)

[i2000s (i2000s)]

Also, I am using Lenovo Thinkpad P50 mobile workstation. I guess tp-smapi hasn't supported it either, maybe?

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Markus Harmsen (markus-harmsen)]

I had exactly the same problem on my T460s running Ubuntu 16.04.1 LTS when installing the 4.7 mainline kernel.
After digging into the /usr/src/tp-smapi-0.41/thinkpad_ec.c file it seems that the module_param_named macro is used wrong: the given variable is an integer and not a boolean. After changing "bool" to "int", the kernel install (including DKMS for tp-smapi) seemed to work.
Currently I'm running the 4.7.0-040700-generic kernel without problems so far.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch.txt" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Evgeni Golov (evgeni)]

Hi,

while your patch will make things work, the right one was applied upstream about two years ago: https://github.com/evgeni/tp_smapi/commit/8f40fcf3d9a4bfb9c3dae1caa2107ea3a367a609 :)

An updated package is available for 16.10.

Why Ubuntu is shipping a kernel which was clearly not tested with all the DKMS packages in the archive is unknown to me. ¯\_(ツ)_/¯

Greets

[robin (robinp)]

Yep, same problem here too. A new kernel doesn't fix it, the only way I could get round it was by manually installing the package from Ubuntu 16.10. Not great, that breaks the whole method of package management which is so great about apt and repositories.

[robin (robinp)]

In lieu of Canonical fixing this properly (really sloppy folks, this is nearly a year old...), linrunner provide an updated package in one of their PPAs:

https://launchpad.net/~linrunner/+archive/ubuntu/tlp

This shouldn't be necessary, fix it the correct way!

[i2000s (i2000s)]

Following robin's link, I have just successfully installed tp-smapi-dkms on my Thinkpad P50 laptop! Thanks. I hope this could be fixed in the xenial official repo soon!

[Andreas Loeffler (lefty01)]

i2000s which kernel version are you using?
I'm running 4.11.0-14-generic #20~16.04.1-Ubuntu SMP (16.04 lts hwe-edge) and installed modules from ppa:linrunner/tlp (same as manually patching and compiling the module...)
but when trying to load tp_smapi I do get an error from the dependent thinkpad_ec module:

[11365.537742] thinkpad_ec: thinkpad_ec_request_row: arg0 rejected: (0x01:0x00)->0x00
[11365.537744] thinkpad_ec: thinkpad_ec_read_row: failed requesting row: (0x01:0x00)->0xfffffffb
[11365.537746] thinkpad_ec: initial ec test failed

this is as well on a thinkpad P50 with latest bios update (as of today).

is there any ideas (can this be discussed here?)?
thx

[robin (robinp)]

Andreas:
https://github.com/evgeni/tp_smapi/issues/14#issuecomment-33732028

I use a T420, so no idea if this is useful or not.

[Rolf Leggewie (r0lf)]

Hello Evgeni, hello folks,

sorry for the long delay in addressing this. I've just found out I am affected and as a user, I might be able and know how to fix it properly in Ubuntu.

Let me please first confirm that this is fixed upstream in the 0.42 release (and thus does not affect z, a and b series of Ubuntu), correct? Let me further confirm that https://github.com/evgeni/tp_smapi/commit/8f40fcf3d9a4bfb9c3dae1caa2107ea3a367a609 is an atomic fix I can simply backport to the 0.41 codebase?

[Larry Wilson (larry2311)]

What is taking so long to fix this the proper way!!!!!

Using the linrunner PPA approach above.

[nevergone (nevergone)]

@r0lf

Yes.

[Larry Wilson (larry2311)]

an update: I noticed that there is an update (0.43-1), which is a fix, via the linrunner PPA using:

add-apt-repository ppa:linrunner/tlp