Make default plugin config styling be "panel panel-body"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Low
|
Aaron Wells |
Bug Description
The plugin config page's page template is basically just this:
{include header.tpl}
{$form|safe}
{include footer.tpl}
In order for the displayed form to look good, it needs to either be in class "panel panel-body", or be made of collapsible fieldsets. All of the core plugins are either made of collapsible fieldsets, or have "class=panel panel-body" declared at the plugin level, in the "get_config_
But third-party plugin developers would have to know to add those two classes. Otherwise, the form is displayed directly on top of the page background, instead of in a white panel on top of the page background.
So what we ought to do, is make "panel panel-body" be the default class for the plugin configuration page.
Changed in mahara: | |
milestone: | none → 16.10.0 |
assignee: | nobody → Aaron Wells (u-aaronw) |
importance: | Undecided → Low |
status: | New → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/6726