Make default plugin config styling be "panel panel-body"

Bug #1603332 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Aaron Wells

Bug Description

The plugin config page's page template is basically just this:

{include header.tpl}
{$form|safe}
{include footer.tpl}

In order for the displayed form to look good, it needs to either be in class "panel panel-body", or be made of collapsible fieldsets. All of the core plugins are either made of collapsible fieldsets, or have "class=panel panel-body" declared at the plugin level, in the "get_config_options()" function for each one.

But third-party plugin developers would have to know to add those two classes. Otherwise, the form is displayed directly on top of the page background, instead of in a white panel on top of the page background.

So what we ought to do, is make "panel panel-body" be the default class for the plugin configuration page.

Aaron Wells (u-aaronw)
Changed in mahara:
milestone: none → 16.10.0
assignee: nobody → Aaron Wells (u-aaronw)
importance: Undecided → Low
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6726

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6726
Committed: https://git.mahara.org/mahara/mahara/commit/d48ab030e9bb983d1dfeb869c47d5463345b6b3d
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit d48ab030e9bb983d1dfeb869c47d5463345b6b3d
Author: Aaron Wells <email address hidden>
Date: Fri Jul 15 19:28:20 2016 +1200

Bug 1603332: Better default styling for plugin config page

Change-Id: I07bb4031679fec26ea0535dc9b6604b5d1c42bc8
behatnotneeded: Covered by existing tests

Son Nguyen (ngson2000)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.