[SRU] New stable micro release 2.12.1

[Sergio Schvezov]

This is an SRU bug to release 2.12.1 of snapcraft which follows the guidelines defined in the wiki over at https://wiki.ubuntu.com/StableReleaseUpdates#Snapcraft

The list of bugs and features in this release are defined at https://launchpad.net/snapcraft/+milestone/2.12.1

[Leo Arias (elopio)]

The following verification is required before landing into Xenial:

go plugin:
 - Build a snap with the snapcraft.yaml in the same branch as the source.
 - Build a snap with the snapcraft.yaml in a different branch, pulling the source.
 - Build a snap without go-importpath, check the warning message.

pkg-config:
 - Build mhall's pantheon snap from bug #1595243.

python3 plugin:
 - Build a snap with an entry_point,

qmake plugin:
 - Build pbek's qownnotes from https://github.com/ubuntu/snappy-playpen/issues/145

parts:
 - Build a snap with a cloud part, without running snapcraft update first.
 - Update the parts cache, try to update it again, check that the second time it's not downloaded.
 - Update the parts cache, change the wiki parts, update the cache again.

store:
 - Upload a snap, check the progress bar and successful message.
 - Upload a snap that requires a manual review.
 - Try to upload a snap not registered.
 - Try to register a snap already registered.
 - Try to register a reserved snap.
 - Try to register two snaps in a minute.

exploratory:
 - Run various commands that will result in error messages, check that the message is not wrapped.
 - Run things with downloads (snap from the store, part from the wiki, source from github), check the progress bar.

[Launchpad Janitor (janitor)]

This bug was fixed in the package snapcraft - 2.12.1+16.10

---------------
snapcraft (2.12.1+16.10) yakkety; urgency=medium

  * New upstream release 2.12.1 (LP: #1600090)

 -- Sergio Schvezov <email address hidden> Fri, 08 Jul 2016 13:31:34 -0300

[Brian Murray (brian-murray)]

Hello Sergio, or anyone else affected,

Accepted snapcraft into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapcraft/2.12.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Leo Arias (elopio)]

Tested in an up-to-date xenial:

Installed snapcraft 2.12
Enabled -proposed.
Upgraded to 2.12.1

go plugin:
 ✓ Build a snap with the snapcraft.yaml in the same branch as the source.
 ✓ Build a snap with the snapcraft.yaml in a different branch, pulling the source.
 ✓ Build a snap without go-importpath, check the warning message.

pkg-config:
 ✗ Build mhall's pantheon snap from bug #1595243.

python3 plugin:
 ✓ Build a snap with an entry_point.
   (Reported bug #1602079 because this is missing an automated test. Not a blocker though because I ran the test manually in this release.)

qmake plugin:
 ✓ Build pbek's qownnotes from https://github.com/ubuntu/snappy-playpen/issues/145
   (The snap is still failing because of a conflict in the env part. That's not a snapcraft error, and the qmake part builds correctly now)

parts:
 ✓ Build a snap with a cloud part, without running snapcraft update first.
 ✓ Update the parts cache, try to update it again, check that the second time it's not downloaded.
 ✓ Update the parts cache, change the wiki parts, update the cache again.

store:
 ✓ Upload a snap, check the progress bar and successful message.
 ✓ Upload a snap that requires a manual review.
 ✓ Try to upload a snap not registered.
 ✓ Try to register a snap already registered.
 ✓ Try to register a reserved snap.
 ✓ Try to register two snaps in a minute.

exploratory:
 ✓ Run various commands that will result in error messages, check that the message is not wrapped.
 ✓ Run things with downloads (snap from the store, part from the wiki, source from github), check the progress bar.

other bugs found during testing:
 - bug #1596779: the error when trying to register a snap without signing the agreement is worse than before. High priority, has to be fixed in the next release.
 - bug #1602091: the error when trying to register a snap that I already registered is not great. Medium priority.
 - bug #1602094: no clear way to solve the missing short namespace on upload. Medium priority.
 - bug #1602095: the manual review error needs to be improved. No priority set yet, needs discussion.

I'm not yet marking this bug as verified because pantheon is still failing to snap. More digging is needed there in order to know if it's because the bug is still open, or there's something else missing by the yaml. That's the only remaining task.

[Leo Arias (elopio)]

I'm marking this as verified now.

I inspected the branch for the pkgconfig, and confirmed that snapcraft 2.12.1 is patching the file as described in the branch. Also, the pantheon snap now passes the "Checking for modules" step, which means that it is now finding the granite library.

It now fails in a different place mentioning that granite is not found in the Vala API or GIR directories. That seems to me a completely different issue, that probably needs to be fixed in the snap or in a part, not in snapcraft.

Thanks Brian for helping with this SRU! Ship it!

[Launchpad Janitor (janitor)]

This bug was fixed in the package snapcraft - 2.12.1

---------------
snapcraft (2.12.1) xenial; urgency=medium

  * New upstream release 2.12.1 (LP: #1600090)

 -- Sergio Schvezov <email address hidden> Fri, 08 Jul 2016 13:31:34 -0300

[Chris J Arges (arges)]

The verification of the Stable Release Update for snapcraft has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.