dependency of metadata service

Bug #1599680 reported by yuanying
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Fix Released
Low
yuanying

Bug Description

`make-cert.sh` scripts uses metadata service to get node public/private
addresses. But it's better to remove dependency of metadata service
if it is possible.

yuanying (yuanying)
Changed in magnum:
importance: Undecided → Low
assignee: nobody → yuanying (ootsuka)
milestone: none → newton-3
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/338623

Changed in magnum:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/338623
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=833392ea9c50ac9c54b9d52c306f3b4f57132f08
Submitter: Jenkins
Branch: master

commit 833392ea9c50ac9c54b9d52c306f3b4f57132f08
Author: OTSUKA, Yuanying <email address hidden>
Date: Thu Jul 7 09:58:05 2016 +0900

    Remove dependency of metadata service

    `make-cert.sh` scripts uses metadata service to get node public/private
    addresses. But it's better to remove dependency of metadata service
    if it is possible.
    This patch make `make-cert.sh` use KUBE_NODE_IP/KUBE_NODE_PUBLIC_IP
    for setting SANs.

    Change-Id: Idb30971e205e8fd94a478ef7d0bc6a30f5cab534
    Closes-Bug: #1599680

Changed in magnum:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum (master)

Fix proposed to branch: master
Review: https://review.openstack.org/347646

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to magnum (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/354031

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum (master)

Reviewed: https://review.openstack.org/347646
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=d5616dc6fedaac9eb6f6a3e287cae86728249c2c
Submitter: Jenkins
Branch: master

commit d5616dc6fedaac9eb6f6a3e287cae86728249c2c
Author: OTSUKA, Yuanying <email address hidden>
Date: Wed Jul 27 15:39:52 2016 +0900

    Re: Remove dependency of metadata service

    This changes were merged into upstream once[1], but lost now.
    So I added this changes again.
    And this fixes issues which occurs if "KUBE_API_PUBLIC_ADDRESS"
    or "KUBE_API_PRIVATE_ADDRESS" are blank.

    [1]: Idb30971e205e8fd94a478ef7d0bc6a30f5cab534

    Change-Id: I0c320ef392fb424755730d4572e744f9c3852c87
    Closes-Bug: #1599680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to magnum (master)

Reviewed: https://review.openstack.org/354031
Committed: https://git.openstack.org/cgit/openstack/magnum/commit/?id=1dff7989144f87f5e6ddca7d282bc8f313ce5b4c
Submitter: Jenkins
Branch: master

commit 1dff7989144f87f5e6ddca7d282bc8f313ce5b4c
Author: Spyros Trigazis <email address hidden>
Date: Thu Aug 11 14:08:11 2016 +0200

    Fix indentation and if expressions in make-cert

    Followup to [1], to fix long lines and if expressions.

    [1] I0c320ef392fb424755730d4572e744f9c3852c87

    Change-Id: I0a29def2b6511f1d8f6190c2e07974ac8d235b46
    Related-Bug #1599680

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum 3.0.0

This issue was fixed in the openstack/magnum 3.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.