Add institution shortname to manually created groups

[Kristina Hoeppner]

In bug ​#826649 new functionality is introduced to Mahara so that all groups can have group shortnames and thus be updated via CSV files. The group shortname was not enough to add though as an institution shortname is needed as well.

Currently, groups created by CSV have to be associated with an institution so that:
1. Institution admins only create groups within their realm of administrative permissions.
2. Institution admins can't bulk add users from other institutions to their group to prevent issues.
3. web services calls can be made in the future to create groups and allow institutions to manage that.

The problem though is that the current screen "Administer groups" doesn't say which groups belong to which institution making it difficult for a site administrator to see which groups can be updated by institution admins and which ones can't because all have a group shortname.

The way forward is the following:

1. Add the institution shortname "mahara" to all manually created groups so that there are no error messages.
2. Implement an institution selector (like we have on Administration -> Users -> User search for example) so that site admins can filter the groups by institution to quickly download the CSV file with all the groups an institution can administer as well as group membership (currently in review).

Additional wishlist items are separately reported and don't form part of this fix:

A. Make "Administer groups" available to institution administrators so that they can see all the groups they can administer, similarly to the "User search" page. Bug #1597134

B. Allow the institution association to be changed so that institution admins could take over a manually created group. Bug #1597136

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/6633

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/6633
Committed: https://git.mahara.org/mahara/mahara/commit/0c6d05d29d2b76fdd406f30ecb71b92492161eb2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0c6d05d29d2b76fdd406f30ecb71b92492161eb2
Author: Robert Lyon <email address hidden>
Date: Wed Jun 29 13:32:46 2016 +1200

Bug 1597133: Adding institutions to groups that don't have them

And adding an institution selection to the Admin -> Group search

Also making sure that we can retain supplied shortname or throw error
if there is a clash

behatnotneeded

Change-Id: Ibbd6c05c1428e522c048b10c64389ebe3360473a
Signed-off-by: Robert Lyon <email address hidden>

[Ghada El-Zoghbi (ghada-z)]

Hi Robert,

Thanks for the patch. We've had a request from one of our clients to improve the error message that's thrown when adding a group through the csv upload and the group name is already in use.

Maybe something like:

 throw new UserException('group_create: The supplied shortname \'' .
                        $data['shortname'] . '\' is already in use. This shortname \'' .
                        $shortname . '\' is available.');

Instead of:

throw new UserException('group_create: problem with supplied shortname ' . $data['shortname'] . ' not matching allowed shortname ' . $shortname);

I'll submit a patch.

[Ghada El-Zoghbi (ghada-z)]

Created a new bug. Please refer to: https://bugs.launchpad.net/mahara/+bug/1600116