Fuel for OpenStack

Interfaces configuration is locked for nodes that got into error state during deployment

Bug #1592998 reported by Vladimir Kuklin on 2016-06-15

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Fuel for OpenStack	Fix Committed	High	Vladimir Kuklin	Fuel for OpenStack 10.0
	Mitaka	Fix Released	High	Vladimir Kuklin	Fuel for OpenStack 9.1

Bug Description

9.0.1 RC1

Deploy an env
Add a compute node with broken ifaces config
Deploy changes
Node gets into error state
Try to change interfaces config to the correct ones
Hit deploy

Expected result:

Changes are accepted by API and it is possible to fix the deployment

Actual result:

400 Client Error: Bad Request for url: http://10.109.0.2:8000/api/v1/nodes/7/interfaces/ (Node '7': Interfaces configuration can't be changed after or during deployment.)

This issue might be considered as critical because

1) users are allowed to change nic configuration of ready nodes including ALL nodes of the cluster
2) they may make a mistake
3) the whole environment will get into state when it is broken and it can be fixed only with a set of tricky manual steps

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-15: Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/330257

Changed in fuel:
status:	Confirmed → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-15: Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/330258

Andrey Maximov (maximov) on 2016-06-16

tags:

added: move-to-mu

Dmitry Pyzhov (dpyzhov) on 2016-06-16

no longer affects:

fuel/newton

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-24: Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/330257
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=ec80be3027595773bd58970666b2697923fb8bba
Submitter: Jenkins
Branch: master

commit ec80be3027595773bd58970666b2697923fb8bba
Author: Vladimir Kuklin <email address hidden>
Date: Thu Jun 16 01:30:23 2016 +0300

Allow to change interfaces configuration for nodes that errored on deployment

    This commit fixes the issue that it is not possible to recover after
    deploying/redeploying a node with broken network interfaces config.
    We allow interfaces configuration for a set of node error states
    including discover and deploy actions.

Minor: Fix pep8 line length complaint.

Change-Id: I8dbaf96c1f89f77e7963d164d2ca4648bcd77fca
Closes-bug: #1592998

Changed in fuel:
status:	In Progress → Fix Committed

Julia Aranovich (jkirnosova) on 2016-06-27

tags:

added: area-ui

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix proposed to fuel-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/334326

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix merged to fuel-ui (master)

Reviewed: https://review.openstack.org/334326
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=41ed4760499798b73c964a777baf7072b5218f85
Submitter: Jenkins
Branch: master

commit 41ed4760499798b73c964a777baf7072b5218f85
Author: Julia Aranovich <email address hidden>
Date: Mon Jun 27 10:41:57 2016 +0300

Unlock interfaces of node with "deploy" error type

    Now configuration of interfaces is allowed for nodes with
    the following statuses:
    * status=discover
    * status=stopped
    * status=error AND error_type=discover
    * status=error AND error_type=deploy

Partial-Bug #1592998

Change-Id: I1941dee125a06c7028c8beadc1dfde96829cbc2e

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-06-27: Fix proposed to fuel-ui (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/334538

Dmitry Pyzhov (dpyzhov) on 2016-08-04

tags:

added: 9.1-proposed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2016-08-17: Fix merged to fuel-ui (stable/mitaka)

Reviewed: https://review.openstack.org/334538
Committed: https://git.openstack.org/cgit/openstack/fuel-ui/commit/?id=69fb04db7a69e2bca3a352fa7501af8e148b7bbf
Submitter: Jenkins
Branch: stable/mitaka

commit 69fb04db7a69e2bca3a352fa7501af8e148b7bbf
Author: Julia Aranovich <email address hidden>
Date: Mon Jun 27 10:41:57 2016 +0300