Documentation symlinks are absolute which doesn't work in snappy

Bug #1592237 reported by Robert Ancell
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Yelp Tools
Expired
Medium
yelp-tools (Ubuntu)
Fix Released
Medium
Unassigned
Xenial
Fix Released
Medium
Unassigned
Yakkety
Fix Released
Medium
Unassigned

Bug Description

[Impact]
If a document has images that aren't translated they are symlinked to the untranslated version. These symlinks are absolute so they can't be relocated and break with snappy.

[Test Case]
Build a project that uses yelp-tools (e.g. ghex). Check the symlinks that are created.

Expected result:
They are relative so the files can be relocated

Observed result:
They are asbsolute.

[Regression Potential]
Low. It seems unlikely that anything would check how the links work.

Changed in yelp-tools (Ubuntu Xenial):
status: New → Confirmed
status: Confirmed → Triaged
Changed in yelp-tools (Ubuntu Yakkety):
status: New → Triaged
Changed in yelp-tools (Ubuntu Xenial):
importance: Undecided → Medium
Changed in yelp-tools (Ubuntu Yakkety):
importance: Undecided → Medium
description: updated
Changed in yelp-tools (Ubuntu Xenial):
status: Triaged → Fix Committed
Changed in yelp-tools (Ubuntu Yakkety):
status: Triaged → Fix Committed
Changed in yelp-tools:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yelp-tools - 3.18.0-1ubuntu1

---------------
yelp-tools (3.18.0-1ubuntu1) yakkety; urgency=medium

  * debian/patches/relative-symlinks.patch:
    - Use relative symlinks to allow relocation (LP: #1592237)

 -- Robert Ancell <email address hidden> Tue, 14 Jun 2016 16:21:05 +1200

Changed in yelp-tools (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Robert, or anyone else affected,

Accepted yelp-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/yelp-tools/3.18.0-1ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Confirmed fixed in Xenial.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package yelp-tools - 3.18.0-1ubuntu0.2

---------------
yelp-tools (3.18.0-1ubuntu0.2) xenial; urgency=medium

  * debian/patches/relative-symlinks.patch:
    - Handle cases where media is in subdirectories

yelp-tools (3.18.0-1ubuntu0.1) xenial; urgency=medium

  * debian/patches/relative-symlinks.patch:
    - Use relative symlinks to allow relocation (LP: #1592237)

 -- Robert Ancell <email address hidden> Thu, 16 Jun 2016 11:52:40 +1200

Changed in yelp-tools (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Chris Halse Rogers (raof) wrote : Update Released

The verification of the Stable Release Update for yelp-tools has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in yelp-tools:
status: Confirmed → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.