Libertine

Need way to add/remove extra bind-mounts inside the container's home directory

Bug #1590051 reported by Christopher Townsend
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libertine
Status tracked in Devel
Devel
Fix Released
Medium
Larry Price
Libertine 1.5
Trunk
Fix Released
Medium
Larry Price
Libertine 1.5
libertine (Ubuntu)
Fix Released
Medium
Larry Price

Bug Description

Currently, only a handful of XDG directories get mapped into the container's "confined" home directory. We need to allow users to define extra bind-mounts from the regular home directory.

We should add bind-mounts in the ContainersConfig.json like this:

{
    "containerList": [
        {
            "bindMounts": [
                {
                    "mount": "Documents"
                },
                {
                    "mount": "Downloads"
                }
            ],
        etc......
}

Related branches

lp:~larryprice/libertine/custom-bind-mounts
Christopher Townsend: Approve
Libertine CI Bot: Approve (continuous-integration)
Diff: 313 lines (+131/-22)
7 files modified
python/libertine/ChrootContainer.py (+7/-1)
python/libertine/ContainersConfig.py (+27/-0)
python/libertine/utils.py (+21/-14)
tools/completions/libertine-container-manager (+5/-3)
tools/libertine-container-manager (+44/-0)
tools/libertine-container-manager.1 (+10/-0)
tools/libertine-lxc-manager (+17/-4)
lp:~townsend/libertine/1.4.4-release
Larry Price: Approve
Diff: 3783 lines (+2969/-70)
59 files modified
data/CMakeLists.txt (+1/-1)
data/com.canonical.libertine.ContainerManager.service (+3/-0)
debian/changelog (+33/-0)
debian/libertine-tools.install (+2/-0)
debian/python3-libertine.install (+1/-0)
debian/rules (+2/-2)
po/CMakeLists.txt (+2/-0)
python/libertine/ChrootContainer.py (+32/-15)
python/libertine/ContainersConfig.py (+38/-6)
python/libertine/HostInfo.py (+1/-1)
python/libertine/Libertine.py (+28/-7)
python/libertine/LxcContainer.py (+11/-5)
python/libertine/launcher/config.py (+1/-1)
python/libertine/service/apt.py (+77/-0)
python/libertine/service/container.py (+139/-0)
python/libertine/service/manager.py (+115/-0)
python/libertine/service/progress.py (+84/-0)
python/libertine/service/task_dispatcher.py (+114/-0)
python/libertine/service/tasks/__init__.py (+39/-0)
python/libertine/service/tasks/app_info_task.py (+35/-0)
python/libertine/service/tasks/base_task.py (+94/-0)
python/libertine/service/tasks/container_info_task.py (+29/-0)
python/libertine/service/tasks/create_task.py (+72/-0)
python/libertine/service/tasks/destroy_task.py (+42/-0)
python/libertine/service/tasks/install_task.py (+49/-0)
python/libertine/service/tasks/list_apps_task.py (+30/-0)
python/libertine/service/tasks/list_task.py (+25/-0)
python/libertine/service/tasks/remove_task.py (+48/-0)
python/libertine/service/tasks/search_task.py (+27/-0)
python/libertine/service/tasks/update_task.py (+39/-0)
python/libertine/utils.py (+34/-17)
tests/CMakeLists.txt (+1/-0)
tests/integration/CMakeLists.txt (+4/-0)
tests/integration/test_libertine_service.py (+176/-0)
tests/unit/CMakeLists.txt (+1/-0)
tests/unit/pytest.ini (+2/-0)
tests/unit/service/CMakeLists.txt (+12/-0)
tests/unit/service/tasks/CMakeLists.txt (+10/-0)
tests/unit/service/tasks/test_app_info_task.py (+61/-0)
tests/unit/service/tasks/test_container_info_task.py (+44/-0)
tests/unit/service/tasks/test_create_task.py (+234/-0)
tests/unit/service/tasks/test_destroy_task.py (+80/-0)
tests/unit/service/tasks/test_install_task.py (+76/-0)
tests/unit/service/tasks/test_list_apps_task.py (+59/-0)
tests/unit/service/tasks/test_list_task.py (+45/-0)
tests/unit/service/tasks/test_remove_task.py (+76/-0)
tests/unit/service/tasks/test_search_task.py (+43/-0)
tests/unit/service/tasks/test_update_task.py (+80/-0)
tests/unit/service/test_apt.py (+134/-0)
tests/unit/service/test_container.py (+202/-0)
tests/unit/service/test_task_dispatcher.py (+148/-0)
tests/unit/test_libertine_container.py (+8/-4)
tools/CMakeLists.txt (+1/-1)
tools/completions/libertine-container-manager (+5/-3)
tools/libertine-container-manager (+46/-2)
tools/libertine-container-manager.1 (+10/-0)
tools/libertine-launch (+6/-1)
tools/libertine-lxc-manager (+17/-4)
tools/libertined (+141/-0)
lp:~ci-train-bot/libertine/libertine-ubuntu-zesty-2266 (Merged)
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Christopher Townsend (townsend)
Changed in libertine:
milestone: 1.2 → 1.3
Christopher Townsend (townsend)
Changed in libertine:
milestone: 1.3 → 1.4
Christopher Townsend (townsend)
Changed in libertine:
milestone: 1.4 → 1.5
Revision history for this message
Libertine CI Bot (libertine-ci-bot) wrote :

Fix committed into lp:libertine at revision 330, scheduled for release in libertine, milestone Unknown

Changed in libertine:
status: In Progress → Fix Committed
Christopher Townsend (townsend)
Changed in libertine (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Larry Price (larryprice)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libertine - 1.4.4+17.04.20161205-0ubuntu1

---------------
libertine (1.4.4+17.04.20161205-0ubuntu1) zesty; urgency=medium

  [ Chris Townsend ]
  * Support arm64 based chroots and add stable overlay PPA for xenial
    based chroots. (LP: #1642324)
  * Support creating a Libertine chroot in a snap environment.
  * Need to disable seccomp for running any proot command in a chroot
    container.
  * Escape the proot XDG bind-mounts with quotes to account for '(n)'
    possibly being added to duplicate paths.
  * Redirect where the container is created when in a snap environment.
  * Exclude XDG_DATA_DIRS from being passed in to a chroot environment.
    Fixes launching some apps in a Snappy Libertine chroot container.
  * Bump version to 1.4.4.

  [ Larry Price ]
  * Immediately exit when no container specified and no default
    available.
  * Use distro name as default codename.
  * Add initial bind-mount operations to libertine-container-manager.
    (LP: #1590051)
  * Gracefully handle bad container ids in libertine-launch.
  * Dump the lxc log after a failed create.
  * Initial implementation of a libertine d-bus service.
  * Make window_manager a member variable on ChrootContainer.
  * Happy path integration tests for libertined endpoints.
  * Update translations build for cmake-extras update.

  [ Ted Gould ]
  * Remove 'LD_LIBRARY_PATH' from the env blacklist.

 -- Christopher Townsend <email address hidden> Mon, 05 Dec 2016 21:10:03 +0000

Changed in libertine (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.