cacti still not compatible with MySQL 5.7 default sql_mode

Bug #1588813 reported by Paul Gevers
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cacti (Ubuntu)
Fix Released
High
Paul Gevers
Xenial
Fix Released
High
Paul Gevers

Bug Description

[Impact]

 * Although bug 1578144 fixed the installability and the fundamental running
   of cacti, multiple functions of the cacti web-page do not work with the
   default MySQL 5.7 sql_mode.

 * The fix forces the sql_mode ONLY_FULL_GROUP_BY setting in the MySQL connection
   to be unset.

[Test Case]

 [ Verify issue ]

 * Install cacti on a xenial system with mysql-server installed. Connect to
   http://localhost/cacti, pass through the install process (i.e. hit "Ok", log
   in with admin/admin credentials and provide a new admin password). Then go
   to the http://localhost/cacti/user_admin.php page. Check that the following
   line appears in the /var/log/cacti/cacti.log file:

06/03/2016 07:44:43 AM - CMDPHP: Poller[0] ERROR: SQL Assoc Failed!, Error:'1055', SQL:"SELECT id, user_auth.username, full_name, realm, enabled, policy_graphs, time, max(time) as dtime FROM user_auth LEFT JOIN user_log ON (user_auth.id = user_log.user_id) GROUP BY id ORDER BY username ASC LIMIT 0,30"

 [ Verify fix ]

 * Same as above, but now without the error appearing.

[Regression Potential]

 * The change is very similar to the fix of bug 1578144, which fixed a
   completely useless package. Due to the nature of the change, either it
   doesn't do anything, or breaks the package completely, so regression is easy
   to check.

[Other Info]

 * I am the maintainer of cacti in Debian and have incorporated this change in
   sid as well. The fix is already in yakkety. Upstream has applied this in
   their git repository as well, although in the past they "didn't support
   MySQL safe mode".

Changed in cacti (Ubuntu Xenial):
status: New → In Progress
status: In Progress → Fix Committed
importance: Undecided → High
assignee: nobody → Paul Gevers (paul-climbing)
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Paul, or anyone else affected,

Accepted cacti into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/cacti/0.8.8f+ds1-4ubuntu4.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
Paul Gevers (paul-climbing) wrote :

Executed the tests: confirm that the new package fixes the problem.

tags: added: verification-done
removed: verification-needed
Changed in cacti (Ubuntu):
status: In Progress → Fix Committed
Martin Pitt (pitti)
Changed in cacti (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cacti - 0.8.8f+ds1-4ubuntu4.16.04.1

---------------
cacti (0.8.8f+ds1-4ubuntu4.16.04.1) xenial; urgency=medium

  * Update make_cacti_sql_mode-strict_compatible.patch to also drop
    ONLY_FULL_GROUP_BY (LP: #1588813)

 -- Paul Gevers <email address hidden> Fri, 03 Jun 2016 13:46:55 +0200

Changed in cacti (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for cacti has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.