Tab completion missing in Juju 2.0 betas

Bug #1588403 reported by Jorge Castro
32
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
High
JuanJo Ciarlante
juju-core (Ubuntu)
Fix Released
Undecided
Unassigned
Xenial
Fix Released
Undecided
Unassigned

Bug Description

Tab completion doesn't work for me with the Juju-devel PPA on Xenial.

Revision history for this message
Tom Barber (spicule) wrote :

I always assume it was yet to be implemented. set -x does nothing, no tab completion and no spam to the terminal.

Revision history for this message
Martin Packman (gz) wrote :

Basic problem seems to be the naming of the file under /usr/share/bash-completion/completions/ - currently the juju 2.0 packages have it as 'juju2' which bash won't invoke for the `juju` name. However, the script is not (yet) relevantly different from the juju 1.25 bash completion, so older versions still existing will make it work as expected.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in juju-core (Ubuntu):
status: New → Confirmed
Martin Packman (gz)
tags: added: bash-completion packaging
Changed in juju-core:
importance: Undecided → High
milestone: none → 2.0.0
status: New → Triaged
Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

So src/github.com/juju/juju/etc/bash_completion.d/juju2 is indeed the cause of the failure. It's not clear why the file was renamed, but I've added a packaging rule to swap the name so it installs into /usr/share/bash-completion/completions/juju-core. We should fix upstream if possible.

In my testing, this resolved issues with bash completion for juju2 and juju1; depending on what is default. However, I was not able to ascertain how to get bash completion for the versioned binary names, ala juju-2.0, juju-1.25.

Revision history for this message
JuanJo Ciarlante (jjo) wrote :

See https://github.com/juju/juju/pull/5057 for *beta9*
and above (ie "applications" instead of "services") -
can try it with:

sudo -i # become root

rm /etc/bash_completion.d/juju2
wget -O /etc/bash_completion.d/juju-2.0 \
  https://raw.githubusercontent.com/jjo/juju/master/etc/bash_completion.d/juju-2.0
wget -O /etc/bash_completion.d/juju-version \
  https://raw.githubusercontent.com/jjo/juju/master/etc/bash_completion.d/juju-version

. /etc/bash_completion

Changed in juju-core:
status: Triaged → Fix Committed
milestone: 2.0.0 → 2.0-beta11
assignee: nobody → JuanJo Ciarlante (jjo)
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0~beta12-0ubuntu3.16.10.1

---------------
juju-core (2.0~beta12-0ubuntu3.16.10.1) yakkety; urgency=medium

  * Add skip to current-manual-provider for bug 1605313 and bug 1605050

 -- Nicholas Skaggs <email address hidden> Thu, 21 Jul 2016 15:12:52 -0400

Changed in juju-core (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Jorge, or anyone else affected,

Accepted juju-core into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/juju-core/2.0~beta12-0ubuntu1.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in juju-core (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package juju-core - 2.0~beta12-0ubuntu1.16.04.1

---------------
juju-core (2.0~beta12-0ubuntu1.16.04.1) xenial-proposed; urgency=medium

  [ Nicholas Skaggs ]
  * New upstream release 2.0-beta12 (LP: #1604137).
  * Update debian/copyright.
  * Add skip to current-manual-provider for bug 1605313 and bug 1605050
  * Fix adt test for manual-provider

  [ Martin Packman ]
  * Allow stripping of go binaries (LP: #1564662).
  * Mark juju-2.0 as conflicting and replacing old ppas (LP: #1600257).
  * Adjust where bash completion script is installed (LP: #1588403).

 -- Nicholas Skaggs <email address hidden> Mon, 18 Jul 2016 14:00:19 -0400

Changed in juju-core (Ubuntu Xenial):
status: Fix Committed → Fix Released
Jorge Castro (jorge)
tags: added: verification-done
removed: verification-needed
affects: juju-core → juju
Changed in juju:
milestone: 2.0-beta11 → none
milestone: none → 2.0-beta11
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.