Remove admin role name 'admin' hardcode

Bug #1587683 reported by OpenStack Infra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Akihiro Motoki

Bug Description

https://review.openstack.org/123741
Dear bug triager. This bug was created since a commit was marked with DOCIMPACT.
Your project "openstack/horizon" is set up so that we directly report the documentation bugs against it. If this needs changing, the docimpact-group option needs to be added for the project. You can ask the OpenStack infra team (#openstack-infra on freenode) for help if you need to.

commit ce5fb26bf5f431f0cdaa6860a732338db868a8fb
Author: Paul Karikh <email address hidden>
Date: Tue Sep 30 14:53:21 2014 +0400

    Remove admin role name 'admin' hardcode

    Because of hardcoding name as the 'admin' was impossible to
    use administrative panel with a custom administrative role name.
    This fix replaces hardcoding the name of the administrative role
    with RBAC policy check.

    DocImpact
    Related commit: https://review.openstack.org/#/c/123745/
    Change-Id: I05c8fc750c56f6f6bb49a435662e821eb0d6ba30
    Closes-Bug: #1161144

Tags: doc horizon
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Hey Paul, could you add a release note for https://review.openstack.org/#/c/123741/ ?

Changed in horizon:
assignee: nobody → Paul Karikh (pkarikh)
milestone: none → newton-2
importance: Undecided → Medium
Changed in horizon:
milestone: newton-2 → newton-3
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Reassigning as no action has been taken.

Changed in horizon:
assignee: Paul Karikh (pkarikh) → Rob Cresswell (robcresswell)
milestone: newton-3 → newton-rc1
Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Paul Karikh (pkarikh)
Revision history for this message
Paul Karikh (pkarikh) wrote :

Taking it back after IRC converation with Rob.

Paul Karikh (pkarikh)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/364810

Changed in horizon:
assignee: Paul Karikh (pkarikh) → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/364810
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=deb4cc1268d172ec4ed5b1c29f14156b7187902d
Submitter: Jenkins
Branch: master

commit deb4cc1268d172ec4ed5b1c29f14156b7187902d
Author: Paul Karikh <email address hidden>
Date: Fri Sep 2 12:54:37 2016 +0300

    Add releasenotes for bug #1161144

    Change-Id: Iea2e293069c57bef03d0ab12e504597bcc7e3654
    Closes-Bug: #1587683

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.0.0rc1

This issue was fixed in the openstack/horizon 10.0.0.0rc1 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.