admin role must be called "admin"

[Jay Buffington]

The admin panel hardcodes the name of admin role as "admin". A line like this exists in dashboards/admin/dashboard.py, dashboards/admin/instances/panel.py and dashboards/admin/overview/panel.py

    permissions = ('openstack.roles.admin',)

I'm unable to call the name of the role admin since my keystone is integrating with a corporate LDAP that I don't completely control.

Can the name of the admin role be configurable?

There is a related bug in django_openstack_auth:
    https://github.com/gabrielhurley/django_openstack_auth/issues/28

[termie (termie)]

My proposal for this would be to have the has_perm call actually backend onto to the openstack policy stuff

https://github.com/gabrielhurley/django_openstack_auth/blob/master/openstack_auth/user.py#L180

Could basically use the policy brain to answer the question instead of hardcoded bits

[Gabriel Hurley (gabriel-hurley)]

We're getting closer on this with the work going into Havana for the common policy engine, but this isn't gonna be 100% fixed in H.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123741

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/123741
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Masco (masco)]

removed the assignee since not active for long time.

[Paul Karikh (pkarikh)]

@Masco my last patchset for this bug was uploaded on 13 Nov, my last comment in gerrit discussion of this patch was on Nov 19, so I'm not sure about "not active for long time". :)

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/123741
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123741
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ce5fb26bf5f431f0cdaa6860a732338db868a8fb
Submitter: Jenkins
Branch: master

commit ce5fb26bf5f431f0cdaa6860a732338db868a8fb
Author: Paul Karikh <email address hidden>
Date: Tue Sep 30 14:53:21 2014 +0400

    Remove admin role name 'admin' hardcode

    Because of hardcoding name as the 'admin' was impossible to
    use administrative panel with a custom administrative role name.
    This fix replaces hardcoding the name of the administrative role
    with RBAC policy check.

    DocImpact
    Related commit: https://review.openstack.org/#/c/123745/
    Change-Id: I05c8fc750c56f6f6bb49a435662e821eb0d6ba30
    Closes-Bug: #1161144

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/323953

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 10.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/323953
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0a8b2062dbde7f1a69a5f6cff52fb4f6a6effe61
Submitter: Jenkins
Branch: stable/mitaka

commit 0a8b2062dbde7f1a69a5f6cff52fb4f6a6effe61
Author: Paul Karikh <email address hidden>
Date: Tue Sep 30 14:53:21 2014 +0400

    Remove admin role name 'admin' hardcode

    Because of hardcoding name as the 'admin' was impossible to
    use administrative panel with a custom administrative role name.
    This fix replaces hardcoding the name of the administrative role
    with RBAC policy check.

    DocImpact
    Related commit: https://review.openstack.org/#/c/123745/
    Change-Id: I05c8fc750c56f6f6bb49a435662e821eb0d6ba30
    Closes-Bug: #1161144
    (cherry picked from commit ce5fb26bf5f431f0cdaa6860a732338db868a8fb)

[Davanum Srinivas (DIMS) (dims-v)]

This issue was fixed in the openstack/horizon 9.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 9.1.0 release.