Deploy additional nodes failed with enable verbose

[Nikita Karpin]

Detailed bug description:
 after change of environment configuration (for example addition of 2 ironic nodes), 'deploy changes' action failed just after deployment start

Steps to reproduce:

1. Deploy cluster with the following configuration:

1x Controller
1x Compute
1x Ironic.

Settings:
Compute - QEMU.
Network - Neutron with VLAN segmentation, DVR enabled.
Storage Backends - Cinder LVM over iSCSI for volumes.
Puppet debug logging - enabled
OpenStack debug logging - enabled

2. Add 1 Ironic and 1 Controller+Ironic node.
3. Deploy changes.
Expected results:
deployment pass
Actual result:
deploy failed. nailgun fails to serialize task graph
Reproducibility:
 n/a
Workaround:
 none
Impact:
 cannot add ironic nodes
Description of the environment:
 Operation system: ubuntu
 Versions of components: 9.0 iso 366
Additional information:
 task "ironic-conductor" failed to evaluate yaql condition. it fails with "KeyError: u'verbose'" exception, and it seems $.verbose doesn't work

    "condition": {
        "yaql_exp": "$.ironic.enabled and changedAny($.network_scheme, $.ironic, $.network_metadata.vips, $.get('database_vip'), $.get('neutron_endpoint'), $.get('glance_api_servers'), $.get('amqp_hosts'), $.debug, $.verbose, $.get('use_syslog'), $.get('syslog_log_facility_ironic'), $.rabbit, $.storage, $.get('kombu_compression'))\n"
    }

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317558
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=bf8f1962a34e724505e3dbe2975db9a359259ebb
Submitter: Jenkins
Branch: master

commit bf8f1962a34e724505e3dbe2975db9a359259ebb
Author: Stanislaw Bogatkin <email address hidden>
Date: Tue May 17 18:08:14 2016 +0300

    Delete 'verbose' parameter from ironic-conductor

    Parameter 'verbose' is deprecated and will be removed from
    ironic ASAP, so we don't need to use it at all.

    Change-Id: Ib7fe815ca07b48ff64fd83cd93c08b444d341166
    Closes-Bug: #1582727

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/317986

[OpenStack Infra (hudson-openstack)]

Change abandoned by Stanislaw Bogatkin (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/317986
Reason: Abandoned in favor of I59ada13003f5239352df4394788b6e5b8789fd53

[Michael Polenchuk (mpolenchuk)]

Actually it was fixed by https://review.openstack.org/317359

[Stanislaw Bogatkin (sbogatkin)]

Btw, it shouldn't be in that patch at all, cause commit message and bug reference was about absolutely another problem. Please, do not make fixes which doesn't written in bug description - it leads us to such problems.

[Michael Polenchuk (mpolenchuk)]

The issue also pointed in:
https://bugs.launchpad.net/fuel/+bug/1578724/comments/9

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317424
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=e10ba1e8781201d7711e903f64bc129dc936d1cc
Submitter: Jenkins
Branch: stable/mitaka

commit e10ba1e8781201d7711e903f64bc129dc936d1cc
Author: Michael Polenchuk <email address hidden>
Date: Tue May 17 15:03:36 2016 +0300

    Get "verbose" key safely for ironic conductor

    * use get("verbose") func in task yaql expr
    * deprecate this option since it has been done
      in oslo.log already

    Change-Id: I59ada13003f5239352df4394788b6e5b8789fd53
    Related-Bug: #1582727

[ElenaRossokhina (esolomina)]

Verified, mos iso 422
[root@nailgun ~]# shotgun2 short-report
cat /etc/fuel_build_id:
 422
cat /etc/fuel_build_number:
 422
cat /etc/fuel_release:
 9.0
cat /etc/fuel_openstack_version:
 mitaka-9.0
rpm -qa | egrep 'fuel|astute|network-checker|nailgun|packetary|shotgun':
 fuel-release-9.0.0-1.mos6347.noarch
 fuel-bootstrap-cli-9.0.0-1.mos284.noarch
 fuel-migrate-9.0.0-1.mos8405.noarch
 rubygem-astute-9.0.0-1.mos746.noarch
 fuel-provisioning-scripts-9.0.0-1.mos8709.noarch
 network-checker-9.0.0-1.mos72.x86_64
 fuel-mirror-9.0.0-1.mos137.noarch
 fuel-openstack-metadata-9.0.0-1.mos8709.noarch
 fuel-notify-9.0.0-1.mos8405.noarch
 nailgun-mcagents-9.0.0-1.mos746.noarch
 python-fuelclient-9.0.0-1.mos317.noarch
 fuelmenu-9.0.0-1.mos270.noarch
 fuel-9.0.0-1.mos6347.noarch
 fuel-utils-9.0.0-1.mos8405.noarch
 fuel-setup-9.0.0-1.mos6347.noarch
 fuel-library9.0-9.0.0-1.mos8405.noarch
 shotgun-9.0.0-1.mos90.noarch
 fuel-agent-9.0.0-1.mos284.noarch
 fuel-ui-9.0.0-1.mos2706.noarch
 fuel-ostf-9.0.0-1.mos934.noarch
 fuel-misc-9.0.0-1.mos8405.noarch
 python-packetary-9.0.0-1.mos137.noarch
 fuel-nailgun-9.0.0-1.mos8709.noarch

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/newton
Review: https://review.openstack.org/421367

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/421415

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/421415
Committed: https://git.openstack.org/cgit/openstack/fuel-library/commit/?id=15ba6adbea125c9f3cbcfade2eb198989a060e1d
Submitter: Jenkins
Branch: master

commit 15ba6adbea125c9f3cbcfade2eb198989a060e1d
Author: Michael Polenchuk <email address hidden>
Date: Tue May 17 15:03:36 2016 +0300

    [sync/mitaka] Get "verbose" key safely for ironic conductor

    * use get("verbose") func in task yaql expr
    * deprecate this option since it has been done
      in oslo.log already

    Change-Id: I59ada13003f5239352df4394788b6e5b8789fd53
    Related-Bug: #1582727

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dmitry Ilyin (<email address hidden>) on branch: stable/newton
Review: https://review.openstack.org/421367