Sync openafs 1.6.17-2 (universe) from Debian unstable (main)

[Anders Kaseorg]

Please sync openafs 1.6.17-2 (universe) from Debian unstable (main)

Explanation of the Ubuntu delta and why it can be dropped:
  * debian/patches/1000-follow-changes-to-key-payload-accessors.patch:
   - follow mainline changes to key payload storage and access.
     (LP: #1538520)
  * debian/patches/1001-follow-changes-to-locks_lock_inode_wait.patch:
   - follow mainline changes to locking switching to
     locks_lock_inode_wait() (LP: #1538520)

All needed patches are in Debian.

Changelog entries since current yakkety version 1.6.15-1ubuntu1:

openafs (1.6.17-2) unstable; urgency=high

  * debian/rules: Fix FTBFS when built with dpkg-buildpackage -A.
    (Closes: #806088)

 -- Anders Kaseorg <email address hidden> Thu, 17 Mar 2016 04:48:16 -0400

openafs (1.6.17-1) unstable; urgency=high

  * New upstream release 1.6.16.
    - Fix bosserver crashes related to fixed-sized buffers.
    - Fix potential denial of service issue in pioctl logic
      (CVE-2015-8312).
    - Provide a new vos remaddrs subcommand for removing server entries.
    - Allow pioctls to work with read-only /proc (e.g. Docker containers).
  * New upstream security release 1.6.17.
    - Prevent users in foreign Kerberos realms from creating groups as if
      they were administrators (CVE-2016-2860).
    - Fix an information leak of uninitialized memory over the network.
    - Fix a crash when the AFS root volume is not found.
  * debian/patches/Linux-4.4-key_payload-has-no-member-value.patch,
    debian/patches/Linux-4.4-Use-locks_lock_file_wait.patch,
    debian/patches/Linux-4.4-Do-not-use-splice.patch:
    Add upstream patches for current Linux kernel support. (Closes: #815521)

 -- Anders Kaseorg <email address hidden> Thu, 17 Mar 2016 00:55:42 -0400

[Michael Hudson-Doyle (mwhudson)]

https://launchpad.net/ubuntu/+source/openafs/1.6.18-1

[Michael Hudson-Doyle (mwhudson)]

The autopkgtests failed on amd64, any thoughts? https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-yakkety/yakkety/amd64/o/openafs/20160518_001941@/log.gz

[Anders Kaseorg (andersk)]

From that log:

> Setting up openafs-modules-dkms (1.6.18-1) ...
> Loading new openafs-1.6.18 DKMS files...
> First Installation: checking all kernels...
> Building only for 4.4.0-22-generic
> Building initial module for 4.4.0-22-generic
> Error! Bad return status for module build on kernel: 4.4.0-22-generic (x86_64)
> Consult /var/lib/dkms/openafs/1.6.18/build/make.log for more information.

So, what is in /var/lib/dkms/openafs/1.6.18/build/make.log?

It works fine for me with the same kernel:

$ dkms status openafs
openafs, 1.6.18, 4.4.0-22-generic, x86_64: installed

[Anders Kaseorg (andersk)]

Ah, found it, by replacing log.gz with artifacts.tar.gz at the end of that URL.

https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-yakkety/yakkety/amd64/o/openafs/20160518_001941@/artifacts.tar.gz

> checking for linux kernel module build works... no
> configure: error: in `/var/lib/dkms/openafs/1.6.18/build':
> configure: error: Fix problem or use --disable-kernel-module...
> See `config.log' for more details

Unfortunately, config.log was not saved.

[Michael Hudson-Doyle (mwhudson)]

Shame. I tried to reproduce but ran into https://bugs.launchpad.net/ubuntu/+source/autopkgtest/+bug/1582960.

[Anders Kaseorg (andersk)]

Okay, after fully upgrading my system to yakkety, because what could possibly go wrong, I can reproduce.

configure:6958: checking for linux kernel module build works
make -C /lib/modules/4.4.0-22-generic/build M=/var/lib/dkms/openafs/1.6.18/build/conftest.dir modules KBUILD_VERBOSE=1
make: Entering directory '/usr/src/linux-headers-4.4.0-22-generic'
test -e include/generated/autoconf.h -a -e include/config/auto.conf || ( \
echo >&2; \
echo >&2 " ERROR: Kernel configuration is invalid."; \
echo >&2 " include/generated/autoconf.h or include/config/auto.conf are missing.";\
echo >&2 " Run 'make oldconfig && make prepare' on kernel src to fix it."; \
echo >&2 ; \
/bin/false)
mkdir -p /var/lib/dkms/openafs/1.6.18/build/conftest.dir/.tmp_versions ; rm -f /var/lib/dkms/openafs/1.6.18/build/conftest.dir/.tmp_versions/*
make -f ./scripts/Makefile.build obj=/var/lib/dkms/openafs/1.6.18/build/conftest.dir
  gcc -Wp,-MD,/var/lib/dkms/openafs/1.6.18/build/conftest.dir/.conftest.o.d -nostdinc -isystem /usr/lib/gcc/x86_64-linux-gnu/5/include -I./arch/x86/include -Iarch/x86/include/generated/uapi -Iarch/x86/include/generated -Iinclude -I./arch/x86/include/uapi -Iarch/x86/include/generated/uapi -I./include/uapi -Iinclude/generated/uapi -include ./include/linux/kconfig.h -Iubuntu/include -D__KERNEL__ -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -std=gnu89 -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx -m64 -falign-jumps=1 -falign-loops=1 -mno-80387 -mno-fp-ret-in-387 -mpreferred-stack-boundary=3 -mskip-rax-setup -mtune=generic -mno-red-zone -mcmodel=kernel -DCONFIG_X86_X32_ABI -DCONFIG_AS_CFI=1 -DCONFIG_AS_CFI_SIGNAL_FRAME=1 -DCONFIG_AS_CFI_SECTIONS=1 -DCONFIG_AS_FXSAVEQ=1 -DCONFIG_AS_SSSE3=1 -DCONFIG_AS_CRC32=1 -DCONFIG_AS_AVX=1 -DCONFIG_AS_AVX2=1 -DCONFIG_AS_SHA1_NI=1 -DCONFIG_AS_SHA256_NI=1 -pipe -Wno-sign-compare -fno-asynchronous-unwind-tables -O2 -fstack-protector-strong -fno-omit-frame-pointer -fno-optimize-sibling-calls -pg -DCC_HAVE_ASM_GOTO -DMODULE -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(conftest)" -D"KBUILD_MODNAME=KBUILD_STR(conftest)" -c -o /var/lib/dkms/openafs/1.6.18/build/conftest.dir/.tmp_conftest.o /var/lib/dkms/openafs/1.6.18/build/conftest.dir/conftest.c
scripts/Makefile.build:264: recipe for target '/var/lib/dkms/openafs/1.6.18/build/conftest.dir/conftest.o' failed
Makefile:1396: recipe for target '_module_/var/lib/dkms/openafs/1.6.18/build/conftest.dir' failed
make: Leaving directory '/usr/src/linux-headers-4.4.0-22-generic'
arch/x86/Makefile:133: stack-protector enabled but compiler support broken
Makefile:670: Cannot use CONFIG_CC_STACKPROTECTOR_STRONG: -fstack-protector-strong not supported by compiler
/var/lib/dkms/openafs/1.6.18/build/conftest.dir/conftest.c:1:0: error: code model kernel does not support PIC mode
 /* confdefs.h */
 ^
make[1]: *** [/var/lib/dkms/openafs/1.6.18/build/conftest.dir/conftest.o] Error 1
make: *** [_module_/var/lib/dkms/openafs/1.6.18/build/...

[Anders Kaseorg (andersk)]

Which is bug 1574982 in GCC.

I’ve tested that the same problem occurs with openafs-modules-dkms 1.6.15-1ubuntu1 on yakkety, so this is not an openafs regression.

[Michael Hudson-Doyle (mwhudson)]

Hm, I don't know the process to skip the autopkgtest bits. I'll try to
find out! (unless that bug gets fixed first).

On 18 May 2016 at 14:19, Anders Kaseorg <email address hidden> wrote:
> Which is bug 1574982 in GCC.
>
> I’ve tested that the same problem occurs with openafs-modules-dkms
> 1.6.15-1ubuntu1 on yakkety, so this is not an openafs regression.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1582077
>
> Title:
> Sync openafs 1.6.17-2 (universe) from Debian unstable (main)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/openafs/+bug/1582077/+subscriptions

[Michael Hudson-Doyle (mwhudson)]

Pitti did that. In -release now.