Pagination broken in MyFriends block

Bug #1581183 reported by Patric Lougheed
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
16.04
Fix Released
High
Unassigned
16.10
Fix Released
High
Robert Lyon

Bug Description

Pagination in myfriends block not working in v16.04.

Tags: pagination
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I get the following when having a few pictures. I suspect that the two Javascripts are interfering.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

The issue of the avatars overlapping is dealt with in bug #1548522.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

We will look into the avatar issue first as resolving that may fix this issue since there is an overlap.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6578

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6587

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6578
Committed: https://git.mahara.org/mahara/mahara/commit/637a7057bf200cd46e0036528354ae20c1d1327b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 637a7057bf200cd46e0036528354ae20c1d1327b
Author: Robert Lyon <email address hidden>
Date: Thu Jun 9 10:14:57 2016 +1200

Bug 1581183: Pagination failing due to wrong id

Also needed the js-masonry to be re-done on json results

behatnotneeded

Change-Id: I3f101d2a141227f74320cf66a2e03123cac5c254
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6587
Committed: https://git.mahara.org/mahara/mahara/commit/367feb64ae953544ea60d64bfb7fe08181b0fe0c
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 367feb64ae953544ea60d64bfb7fe08181b0fe0c
Author: Robert Lyon <email address hidden>
Date: Thu Jun 9 10:14:57 2016 +1200

Bug 1581183: Pagination failing due to wrong id

Also needed the js-masonry to be re-done on json results

behatnotneeded

Change-Id: I3f101d2a141227f74320cf66a2e03123cac5c254
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 16.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.