pcsd does not start due to missing ruby gem orderedhash

[Tommy Giesler]

[Impact]

 * PCS doesn't work without gem not included in distro.

[Test Case]

 * Install PCS in Xenial and check errors.

[Regression Potential]

 * None since the tool doesn't work.

[Other Info]

 * Fixing LP: #1580035 in SRU for LP: #1640919.

[Original Description]

Greetings,

after the first installation of pcs on a freshly installed Ubuntu 16.04 minimal the pcsd cannot start because of a missing gem.

----------------->%-----------------
lsb_release -rd
Description: Ubuntu 16.04 LTS
Release: 16.04
-----------------%<-----------------
apt-cache policy pcs
pcs:
  Installed: 0.9.149-1
  Candidate: 0.9.149-1
  Version table:
 *** 0.9.149-1 500
        500 http://mirror.hetzner.de/ubuntu/packages xenial/universe amd64 Packages
        500 http://de.archive.ubuntu.com/ubuntu xenial/universe amd64 Packages
        100 /var/lib/dpkg/status
----------------->%-----------------

----------------->%-----------------
root@Ubuntu-1604-xenial-64-minimal ~ # journalctl -u pcsd
-- Logs begin at Tue 2016-05-10 08:12:21 CEST, end at Tue 2016-05-10 08:20:02 CEST. --
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal systemd[1]: Started PCS GUI and remote configuration interface.
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- orderedhash (LoadError)
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/vendor_ruby/backports/std_lib.rb:9:in `require_with_backports'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/share/pcsd/config.rb:2:in `<top (required)>'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/vendor_ruby/backports/std_lib.rb:9:in `require_with_backports'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/share/pcsd/pcs.rb:12:in `<top (required)>'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal ruby[11517]: from /usr/share/pcsd/ssl.rb:7:in `<main>'
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal systemd[1]: pcsd.service: Main process exited, code=exited, status=1/FAILURE
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal systemd[1]: pcsd.service: Unit entered failed state.
May 10 08:15:28 Ubuntu-1604-xenial-64-minimal systemd[1]: pcsd.service: Failed with result 'exit-code'.
-----------------%<-----------------

After installing the gem manually it runs fine:
----------------->%-----------------
root@Ubuntu-1604-xenial-64-minimal ~ # gem install orderedhash
Fetching: orderedhash-0.0.6.gem (100%)
Successfully installed orderedhash-0.0.6
Parsing documentation for orderedhash-0.0.6
Installing ri documentation for orderedhash-0.0.6
Done installing documentation for orderedhash after 0 seconds
1 gem installed
root@Ubuntu-1604-xenial-64-minimal ~ # systemctl restart pcsd.service
root@Ubuntu-1604-xenial-64-minimal ~ # systemctl status pcsd.service
â pcsd.service - PCS GUI and remote configuration interface
   Loaded: loaded (/lib/systemd/system/pcsd.service; enabled; vendor preset: enabled)
   Active: active (running) since Tue 2016-05-10 08:21:07 CEST; 4s ago
 Main PID: 11607 (ruby)
    Tasks: 4 (limit: 512)
   CGroup: /system.slice/pcsd.service
           ââ11607 /usr/bin/ruby -C/var/lib/pcsd -I/usr/share/pcsd -- /usr/share/pcsd/ssl.rb & > /dev/null &

May 10 08:21:07 Ubuntu-1604-xenial-64-minimal systemd[1]: Started PCS GUI and remote configuration interface.
-----------------%<-----------------

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Rafael David Tinoco (rafaeldtinoco)]

The following patch:

http://paste.ubuntu.com/23477943/
(0006-Replace-orderedhash.patch)

Came from Debian BUG:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=818760

And was added in pcs version 0.9.151-1.

Judging by this comment:
"""
Thanks for reporting this bug.

Because orderedhash isn't packaged yet we can't just add it as dependency.

I had a look at the gem. I've noticed that the author didn't specify a
license for his gem which (IMHO) is a blocker for packaging orderedhash.
I will try to contact the author and get the needed licensing information.

Cheers,
 - Adrian
"""

We can't add the needed package and that is why we have to include this patch (not available upstream). Since it was added in release 0.9.151-1, this bug is affecting only pcs | 0.9.149-1 | xenial/universe and not yakkety (or devel).

[Rafael David Tinoco (rafaeldtinoco)]

Cases:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580035
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1580045
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640923
https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919

Are all being fixed into:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1640919
(check this case for the SRU proposal/patches)

[Brian Murray (brian-murray)]

Hello Tommy, or anyone else affected,

Accepted pcs into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/pcs/0.9.149-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Felipe Reyes (freyes)]

The version available in xenial-proposed does fix this issue. Evidence -> http://pastebin.ubuntu.com/23735665/

[Launchpad Janitor (janitor)]

This bug was fixed in the package pcs - 0.9.149-1ubuntu1

---------------
pcs (0.9.149-1ubuntu1) xenial; urgency=medium

  * Patch d/p/0006-Replace-orderedhash.patch added by Debian (LP: #1580035)
    Orderedhash gem can't be used due to licensing issues.
    Dependency package orderedhash replaced by activesupport.
    The daemon was not functional in Xenial before this.
  * Patch d/p/0007-Fix-IPv6-bind.patch (LP: #1580045)
    The daemon was being initialized listening only for IPv6 protocol.
  * Patch d/p/0008-Find-on-specific-directories-only.patch (LP: #1640919)
    Cleaning files when destroying a cluster was taking too long in /var/lib.
    Specifying /var/lib/pacemaker for "finding" leftovers solves the issue.

 -- Rafael David Tinoco <email address hidden> Fri, 09 Dec 2016 03:07:25 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for pcs has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.