blank return strings from processing scripts cause json parse error

Bug #1575377 reported by Adam Stokes
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
conjure-up (Ubuntu)
Fix Released
Critical
Adam Stokes
Xenial
Fix Released
Undecided
Unassigned

Bug Description

[Impact]
This will break any post processing script attempting to retry a invalid JSON string.

[Test Case]
Simply running `conjure-up openstack` through to the end will show this error.

[Regression Potential]
This should be minimal as we add additional exception handling to gracefully deal with these errors.

[Additional Info]
During parsing of results from post processing scripts that return a JSON dictionary and error would occur if that JSON response was not properly formatted or an empty string.

Changed in conjure-up (Ubuntu):
assignee: nobody → Adam Stokes (adam-stokes)
importance: Undecided → Critical
status: New → In Progress
description: updated
Revision history for this message
Martin Pitt (pitti) wrote :

Please upload the fix to yakkety, or if it already is fixed in 2.0 please close the floating task. Otherwise this can't progress into xenial-updates.

Changed in conjure-up (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Hello Adam, or anyone else affected,

Accepted conjure-up into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/conjure-up/0.1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in conjure-up (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Mike McCracken (mikemc) wrote :

I verified that an install finished cleanly with no JSON parsing errors using 0.1.1

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package conjure-up - 0.1.1

---------------
conjure-up (0.1.1) xenial-proposed; urgency=medium

  * Retry on JSON errors (LP: #1575377)

 -- Michael McCracken <email address hidden> Wed, 20 Apr 2016 13:50:00 -0700

Changed in conjure-up (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Update Released

The verification of the Stable Release Update for conjure-up has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.