Ubuntu RTM
ubuntu-ui-toolkit package

UITK trunk has pep8 errors

Bug #1572981 reported by Zoltan Balogh
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Critical
Zoltan Balogh
Canonical System Image 11 "OTA11"
ubuntu-ui-toolkit (Ubuntu RTM)
Fix Released
Critical
Unassigned

Bug Description

Setting up pep8 (1.5.7-2) ...
+ pep8 --repeat --show-source .
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:32:80: E501 line too long (88 > 79 characters)
        self.scrollingSections = self.app.select_single(objectName='scrolling_sections')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:34:80: E501 line too long (82 > 79 characters)
        self.scrollingLabel = self.app.select_single(objectName='scrolling_label')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:36:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 0 is selected.')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:50:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 2 is selected.')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:55:80: E501 line too long (88 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 15 is selected.')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:58:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 1 is selected.')
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py:195:80: E501 line too long (81 > 79 characters)
        logger.info("Not going to use Maliit - set UITK_USE_MALIIT to enable it")
                                                                               ^
./tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py:120:25: E703 statement ends with a semicolon
            return False;
                        ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:32:80: E501 line too long (88 > 79 characters)
        self.scrollingSections = self.app.select_single(objectName='scrolling_sections')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:34:80: E501 line too long (82 > 79 characters)
        self.scrollingLabel = self.app.select_single(objectName='scrolling_label')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:36:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 0 is selected.')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:50:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 2 is selected.')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:55:80: E501 line too long (88 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 15 is selected.')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:58:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 1 is selected.')
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/_custom_proxy_objects/_common.py:195:80: E501 line too long (81 > 79 characters)
        logger.info("Not going to use Maliit - set UITK_USE_MALIIT to enable it")
                                                                               ^
./debian/ubuntu-ui-toolkit-autopilot/usr/lib/python3/dist-packages/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py:120:25: E703 statement ends with a semicolon
            return False;
                        ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:32:80: E501 line too long (88 > 79 characters)
        self.scrollingSections = self.app.select_single(objectName='scrolling_sections')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:34:80: E501 line too long (82 > 79 characters)
        self.scrollingLabel = self.app.select_single(objectName='scrolling_label')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:36:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 0 is selected.')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:50:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 2 is selected.')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:55:80: E501 line too long (88 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 15 is selected.')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py:58:80: E501 line too long (87 > 79 characters)
        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 1 is selected.')
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/_custom_proxy_objects/_common.py:195:80: E501 line too long (81 > 79 characters)
        logger.info("Not going to use Maliit - set UITK_USE_MALIIT to enable it")
                                                                               ^
./debian/tmp/usr/lib/python3/dist-packages/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py:120:25: E703 statement ends with a semicolon
            return False;
                        ^
./.bazaar/plugins/packaging_sorting.py:23:1: E302 expected 2 blank lines, found 1
def pre_commit_hook(local, master, old_revno, old_revid, future_revno,
^
./.bazaar/plugins/packaging_sorting.py:23:71: W291 trailing whitespace
def pre_commit_hook(local, master, old_revno, old_revid, future_revno,
                                                                      ^
./.bazaar/plugins/packaging_sorting.py:31:7: E111 indentation is not a multiple of four
      raise errors.BzrError("Please install 'devscripts' package.")
      ^
./.bazaar/plugins/packaging_sorting.py:32:7: E111 indentation is not a multiple of four
      return
      ^
./.bazaar/plugins/packaging_sorting.py:34:80: E501 line too long (82 > 79 characters)
    subprocess.call(["cp", "-a", "debian", "debian-packaging-wraptest-temporary"])
                                                                               ^
./.bazaar/plugins/packaging_sorting.py:39:9: E128 continuation line under-indented for visual indent
        "debian-packaging-wraptest-temporary", "debian"])
        ^
./.bazaar/plugins/packaging_sorting.py:41:7: E111 indentation is not a multiple of four
      subprocess.call(["rm", "-rf", "debian-packaging-wraptest-temporary"])
      ^
./.bazaar/plugins/packaging_sorting.py:42:7: E111 indentation is not a multiple of four
      raise errors.BzrError("Please run wrap-and-sort -a -t to clean up packaging.")
      ^
./.bazaar/plugins/packaging_sorting.py:42:80: E501 line too long (84 > 79 characters)
      raise errors.BzrError("Please run wrap-and-sort -a -t to clean up packaging.")
                                                                               ^
./.bazaar/plugins/packaging_sorting.py:46:80: E501 line too long (96 > 79 characters)

Related branches

lp:~bzoltan/ubuntu-ui-toolkit/Make_pep8_happy_with_all_the_python_scripts
ubuntu-sdk-build-bot: Approve (continuous-integration)
Tim Peeters: Approve
Timo Jyrinki: Approve
Diff: 436 lines (+146/-132)
9 files modified
.bazaar/plugins/packaging_sorting.py (+18/-9)
documentation/autopilot-helpers/conf.py (+4/-3)
tests/autopilot/ubuntuuitoolkit/__init__.py (+36/-38)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/__init__.py (+31/-32)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_common.py (+2/-1)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_header.py (+3/-2)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py (+5/-5)
tests/autopilot/ubuntuuitoolkit/emulators.py (+35/-36)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py (+12/-6)
lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/dashOfGroundPepper
ubuntu-sdk-build-bot: Approve (continuous-integration)
Timo Jyrinki: Approve
Zoltan Balogh: Approve
Diff: 81 lines (+20/-5)
4 files modified
debian/control (+1/-0)
debian/control.gles (+1/-0)
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py (+16/-4)
ubuntu-sdk.pro (+2/-1)
Zoltan Balogh (bzoltan)
affects: ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit (Ubuntu RTM)
Timo Jyrinki (timo-jyrinki)
Changed in canonical-devices-system-image:
assignee: nobody → Zoltan Balogh (bzoltan)
status: New → In Progress
importance: Undecided → Critical
milestone: none → 11
Revision history for this message
Cris Dywan (kalikiana) wrote :

The fix isn't good enough. It breaks one of the test functions and doesn't pass pep8 on Jenkins:

/tmp/buildd/ubuntu-ui-toolkit-1.3.1938+16.04.20160416/tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_qquicklistview.py:73:33: E701 multiple statements on one line (colon)

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: Fix Committed → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug was fixed in the package ubuntu-ui-toolkit 1.3.1949+15.04.20160421 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

ubuntu-ui-toolkit (1.3.1949+15.04.20160421) vivid; urgency=medium

  [ Zoltan Balogh ]
  * Make pep8 happy with all the python scripts of the UITK project.
    Fixes LP: #1454322, LP: #1572981

  [ Tim Peeters ]
  * Update Header.flickable docs. Fixes LP: #1572525
  * Fix app freeze after closing Dialog/Popover. Fixes LP: #1568016.
  * Fix the tests for focus restoration in tst_focus.qml. Fixes LP: #1572983
  * Update PageStack unit tests to use PageHeader. Fixes LP: #1572988

  [ Pierre Bertet ]
  * Minor optimization on the palette values declaration.

  [ Christian Dywan ]
  * Allow SEGFAULTing tests to be flagged as exceptions. Fixes LP: #1572990

  [ CI Train Bot ]
  * No-change rebuild.

 -- Zoltan Balogh <email address hidden> Thu, 21 Apr 2016 12:06:31 +0000

Changed in ubuntu-ui-toolkit (Ubuntu RTM):
status: In Progress → Fix Released
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.