[SRU] 3G (WWAN) icon missing

[Kristin Chuang]

[Impact]

In this report we are trying to address several issues network-manager-applet 1.2.0-0ubuntu0.16.04.1 suffers by doing cherry-picks from upstream 1.2 stable branch.

By using a 3G WWAN dongle, after establishing a 3G connection, the icon shown in system tray should be a 3G indicator to indicate that 3G is connected. However, in Xenial there is no 3G icon at all. After 3G connection is established, it remains as the previous icon displayed.

[Test Case]

By upgrading to the -proposed package, the icon shown in system tray should be a 3G indicator to indicate that 3G is connected when using WWAN.

[Regression Potential]

This update also includes patches targeting other issues which are not related to this bug directly, but all these fix are clear and have minimum changes, chance of regression is limited.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Christian Reis (kiko)]

Kristin is exactly right -- I just upgraded to Xenial and and I can see the same. I'm attaching screenshots that demonstrate the issue.

[Chih-Hsyuan Ho (chih)]

The last known working network-manger-applet is of 1.0.10-1ubuntu1

[Christian Reis (kiko)]

I think the package name is network-manager-gnome correct? Trusty has 0.9.8.8-0ubuntu4.4, Xenial has 1.1.93-1ubuntu1.

[Christian Reis (kiko)]

This 2012 bug upstream appears identical: https://bugzilla.gnome.org/show_bug.cgi?id=667727

[Christian Reis (kiko)]

Ah, no, in that case the whole icon disappeared.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jerry_Chen8 (jerry-chen8)]

Hi Chih,
Can we raise it to the proper channel that can deliver the fix before project RTS.

[Will Cooke (willcooke)]

Added to Trello: https://trello.com/c/s4rk8M8W/2-bug-1571574-3g-icon-missing-in-network-manager-applet

[Will Cooke (willcooke)]

Added to Trello: https://trello.com/c/QoOJTmAl/21-bug-1571574-3g-icon-missing-in-network-manager-applet

[Sebastien Bacher (seb128)]

Could you look to syslog if there is any networkmanager warning about missing icon? does it work if you use another icon theme (e.g adwaita, the upstream one)?

[Sebastien Bacher (seb128)]

could somebody provide their syslog?

[Kristin Chuang (kristinchuang)]

Please refer to the attached syslog

[Pascal Morin (pcm689)]

@Sebastien & Aron

The syslog is now included; Can we get a resolution very soon; It is urgent issue for Dell. If you want more background please let me know by email or on irc.

Thx.

Pascal

[Sebastien Bacher (seb128)]

@Pascal, thanks for the log, I don't see error about icons there. It's a bit difficult to debug without having a config to trigger the issue ... could you try also with the Adwaita icon theme to see if it might be an icon missing in our theme?

[Sebastien Bacher (seb128)]

Also what was the behaviour on previous Ubuntu series? Did it use to work?

[Pascal Morin (pcm689)]

@Sebastien

The last known working network-manger-applet/gnome version for Xenial is 1.0.10-1ubuntu1 https://bugs.launchpad.net/somerville/ford-constantine/+bug/1571479/comments/6

it used to work fine on Xenial daily builds built before 3/29.

It looks like to be a regression.

[Kristin Chuang (kristinchuang)]

With adwaita-icon-theme (3.18.0-2ubuntu3.1), the issue still occurs.
Please refer to the screenshots attached in following comments for details.

[Kristin Chuang (kristinchuang)]

Xenial + adwaita-icon-theme (3.18.0-2ubuntu3.1) with no network connection established:

The network icon is a "no network connected" icon [OK]

[Kristin Chuang (kristinchuang)]

Xenial + adwaita-icon-theme (3.18.0-2ubuntu3.1) with 3G connection established:

The network icon is still a "no network connected" icon [not OK]

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Kristin Chuang (kristinchuang)]

Issue still occurs after updating to
- network-manager version 1.2.2-0~201605130755~ubuntu16.04.1 and
- network-manager-gnome version 1.2.2-0~201605201009~ubuntu16.04.1

[Kristin Chuang (kristinchuang)]

Issue also still occurs if keeping network manager 1.1.93 and updating network-manager-gnome only to network-manager-gnome version 1.2.2-0~201605201009~ubuntu16.04.1

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-applet - 1.2.0-0ubuntu2

---------------
network-manager-applet (1.2.0-0ubuntu2) yakkety; urgency=medium

  * debian/patches/ubuntu-vpn-icon-name.patch: set out_icon_name as well in
    mobile_helper_get_icon method in mobile helpers; this makes sure we do
    have an icon set for mobile (3G/4G), and not left with the last one that
    was used in the applet. (LP: #1571574)
  * debian/patches/git_fix_assert_p12_privkey_037c5721.patch: fix assertion
    in default_filter_privkey() so we can correctly accept certificates with
    the .p12 extension. (LP: #1583075)

 -- Mathieu Trudel-Lapierre <email address hidden> Fri, 20 May 2016 11:14:13 -0400

[Sebastien Bacher (seb128)]

SRU for xenial should be uploaded tomorrow, Aron is working on that now ... if somebody could test the version uploaded to y or the patch backported to confirm it works for you as well that would be useful

[Franz Hsieh (franz-hsieh)]

@Mathieu,

Thanks for your patch, I just found the same root cause as your. The mobile_helper_get_icon does not return icon file name and result in 'nm-no-connection' is always used on indicator menu:

#ifdef WITH_APPINDICATOR
        if (INDICATOR_ENABLED (applet)) {
                /* FIXME: We rely on the fact that VPN icon gets drawn later and therefore
                 * wins but we cannot currently set a combined pixmap made of both the link
                 * icon and the VPN icon.
                 */
                if (icon_name == NULL && layer == ICON_LAYER_LINK)
                        icon_name = "nm-no-connection";
                if (icon_name != NULL && g_strcmp0 (app_indicator_get_icon (applet->app_indicator), icon_name) != 0)
                        app_indicator_set_icon_full (applet->app_indicator, icon_name, applet->tip);
                return;
        }
#endif /* WITH_APPINDICATOR */

I will install the update from -propose for test if it is available. Thanks!

[Scott McKenzie (noizyland)]

I'd like to test the fix but I can't find the network-manager-applet package. I have enabled the proposed repo but apt-cache policy network-manager-applet tells me "Unable to locate package network-manager-applet".

[Martin Pitt (pitti)]

Hello Kristin, or anyone else affected,

Accepted network-manager-applet into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager-applet/1.2.0-0ubuntu0.16.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Scott McKenzie (noizyland)]

I have installed network-manager-gnome/1.2.0-0ubuntu0.16.04.2. It now displays the wifi icon (/usr/share/icons/ubuntu-mono-dark/status/24/nm-device-wireless.svg) when WWAN is connected, not the WWAN icon (/usr/share/icons/ubuntu-mono-dark/status/24/nm-device-wwan.svg).

[Kristin Chuang (kristinchuang)]

Hi Martin,

I'm afraid that just like Scott's, my verification failed as well.

After upgrading to network-manager-applet version 1.2.0-0ubuntu0.16.04.2, it now shows the fan-like "wifi icon" when WWAN connection is established.

The expected icon should be a mobilebroadband-specific icon (the icon displayed in the WWAN "connection established" bubble that pops up when 3G/WWAN connection is established.)

Here are my verification steps:
----------
1. Go to "Software & Updates" > "Developer Options" tab > tick "Pre-released updates (xenial-proposed)" > save changes

2. Perform the following commands:
$ sudo apt-get update
$ sudo apt-get install gir1.2-nma-1.0 gir1.2-nmgtk-1.0 libnm-gtk-common libnm-gtk0 libnma-common libnma0 network-manager-gnome
$ sudo reboot

3. Make sure no network connection (wifi, ethernet, wwan) is connected.

4. Connect to a mobile network and check the icon displayed in network-applet
----------

[Pascal Morin (pcm689)]

Here is possibly (maybe) the reason (feedback from Franz):

applet-device-wifi.c: (used for WIFI to create icon)

1480 case NM_DEVICE_STATE_ACTIVATED:
1481 strength = ap ? nm_access_point_get_strength (ap) : 0;
1482 strength = MIN (strength, 100);
1483
1484 *out_icon_name = mobile_helper_get_quality_icon_name (strength);
1485
1486 if (ap) {
1487 char *ssid = get

  mobile_helper_get_icon.c (used for WWAN to create icon)

613 case NM_DEVICE_STATE_ACTIVATED:
614 *out_pixbuf = mobile_helper_get_status_pixbuf (quality,
615 quality_valid,
616 mb_state,
617 mb_tech,
618 applet);
619 *out_icon_name = mobile_helper_get_quality_icon_name (quality_valid ?
620 quality : 0);

[Mathieu Trudel-Lapierre (cyphermox)]

Sorry, no. This is indeed the expected icon for 3G in this case -- we don't have a different icon specifically for mobile.

[Mathieu Trudel-Lapierre (cyphermox)]

Humm, actually, scratch that. There *is* gsm-3g-*(-secure).svg available; we could indeed use that instead of nm-signal-*, since it's available.

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-applet - 1.2.0-0ubuntu3

---------------
network-manager-applet (1.2.0-0ubuntu3) yakkety; urgency=medium

  * debian/patches/ubuntu-wwan-icon-name.patch: when setting icon name for
    mobile data, use the "gsm-3g-*" icons we already have and pick them by
    providing a new get_mobile_quality_icon method based on the original.
    (LP: #1571574)

 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 26 May 2016 10:29:02 -0400

[Kristin Chuang (kristinchuang)]

The Yakkety network-manager-applet (1.2.0-0ubuntu3) packages from comment #37 returned positive results on Xenial.

Details below:

(1) Downloaded packages from https://launchpad.net/ubuntu/+source/network-manager-applet/1.2.0-0ubuntu3/+build/9813691 and install them to a Xenial system.

(2) Disconnect all network connections

(3) Connect to a 3G network
=> A mobile-specific icon correctly displayed in network-applet. [OK]

(4) Connect/disconnect antennas to the system to change 3G signal strength
=> the mobile-specific icon changes accordingly. [OK]

[Mathieu Trudel-Lapierre (cyphermox)]

Since I uploaded network-manager-applet (1.2.0-0ubuntu3) to use proper gsm icons; I also pushed a new SRU to the xenial queue for review by the SRU team.

[Adam Conrad (adconrad)]

Hello Kristin, or anyone else affected,

Accepted network-manager-applet into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager-applet/1.2.0-0ubuntu0.16.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Kristin Chuang (kristinchuang)]

Packages for network-manager-applet 1.2.0-0ubuntu0.16.04.3 solved the icon issue.

Verification steps:
----------
1. Go to "Software & Updates" > "Developer Options" tab > tick "Pre-released updates (xenial-proposed)" > save changes

2. Perform the following commands:
$ sudo apt-get update
$ sudo apt-get install gir1.2-nma-1.0 gir1.2-nmgtk-1.0 libnm-gtk-common libnm-gtk0 libnma-common libnma0 network-manager-gnome
$ sudo reboot

3. Make sure no network connection (wifi, ethernet, wwan) is connected.

4. Connect to a mobile network => mobile icon is shown [OK]

5. Connect/disconnect antennas to the system => icon changes in accordance to signal strength. [OK]

[Launchpad Janitor (janitor)]

This bug was fixed in the package network-manager-applet - 1.2.0-0ubuntu0.16.04.3

---------------
network-manager-applet (1.2.0-0ubuntu0.16.04.3) xenial; urgency=medium

  * debian/patches/apple-set-out_icon_name-for-WWAN-connections-for-ind.patch:
    use available gsm-3g-* icons so that the icon for mobile is different than
    that used for wifi; to avoid confusing people. (LP: #1571574)

network-manager-applet (1.2.0-0ubuntu0.16.04.2) xenial; urgency=medium

  * cherry-pick upstream patches from post 1.2.2:
    - wireless-security-fix-failed-assertion-in-default_fi.patch:
      Fix TLS cert authentication (LP: #1575614)
    - wireless-security-return-error-on-eap_method_validat.patch:
      Return error on eap_method_validate_filepicker() failure
    - applet-remove-assert-s_con-from-applet_get_active_vp.patch
      Remove the assert which lead to many false assertions (LP: #1578962)
    - apple-set-out_icon_name-for-WWAN-connections-for-ind.patch
      WWAN icon should appear when the connection is activated (LP: #1571574)

 -- Mathieu Trudel-Lapierre <email address hidden> Wed, 01 Jun 2016 15:15:49 -0400

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for network-manager-applet has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.