memory leak caused by snmp plugin for collectd 5.4.0 (trusty)

Bug #1566890 reported by soybean
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
collectd (Ubuntu)
Fix Released
Medium
Unassigned
Trusty
Fix Released
Medium
Michael Terry

Bug Description

snmp plugin for collectd 5.4.0-3ubuntu2.1 (trusty) causes a memory leak.
The package for 5.4.1-6ubuntu1 (vivid) has already been patched.
(See https://launchpad.net/ubuntu/+source/collectd/5.4.1-6ubuntu1)
So I would like to backport this fix and have included a debdiff against the current package in Trusty.

The patch is based on those commits:
https://github.com/collectd/collectd/issues/610
https://github.com/collectd/collectd/issues/804

Revision history for this message
soybean (warau) wrote :
description: updated
soybean (warau)
description: updated
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "Backport of the upstream fix for memory leak" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Mathew Hodson (mhodson)
tags: added: trusty
Changed in collectd (Ubuntu):
importance: Undecided → Medium
Michael Terry (mterry)
Changed in collectd (Ubuntu):
status: New → Fix Released
Revision history for this message
Michael Terry (mterry) wrote :

Thanks for the patch, soybean! I've uploaded to trusty-proposed, please test once it becomes available.

Changed in collectd (Ubuntu Trusty):
status: New → In Progress
assignee: nobody → Michael Terry (mterry)
Revision history for this message
soybean (warau) wrote :

Thanks, too, Michael!
But I'm afraid that I cannot find collectd in trusty-proposed repository...
(I followed this guide: https://wiki.ubuntu.com/Testing/EnableProposed)
Can you double-check that the package is there?

Revision history for this message
Michael Terry (mterry) wrote :

soybean, you're doing things correctly. It has to be approved by the archive admins, and then it will enter -proposed. So I guess it's currently in -proposed-proposed. :)

Revision history for this message
soybean (warau) wrote :

Aha, I see :) Then, I'll be just waiting a little more.

Revision history for this message
Mathew Hodson (mhodson) wrote :

You can see it's still in the upload queue at https://launchpad.net/ubuntu/trusty/+queue?queue_state=1

Once it's accepted, it will be available in trusty-proposed.

Mathew Hodson (mhodson)
Changed in collectd (Ubuntu Trusty):
importance: Undecided → Medium
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello soybean, or anyone else affected,

Accepted collectd into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/collectd/5.4.0-3ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in collectd (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
soybean (warau) wrote :

Thanks a lot!
The fix seems to work well. SNMP-plugin does not cause a memory leak.

I've even attached a screen shot of the graph from graphite, to which collectd sends data.
I switched from 5.4.0-3ubuntu2.1 to 5.4.0-3ubuntu2.2 around 12:30.
It is fun to see that the graph shows so clearly the difference :)

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package collectd - 5.4.0-3ubuntu2.2

---------------
collectd (5.4.0-3ubuntu2.2) trusty; urgency=medium

  * debian/patches:
    - Added bts770688_snmp_memleak: backport of upstream fix for a memory
      leak in the SNMP plugin, which is included in 5.4.1-6 unstable;
      thanks to Marc Fournier for reporting this. (LP: #1566890)

 -- Akiko Kanno <email address hidden> Wed, 06 Apr 2016 15:12:55 +0200

Changed in collectd (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for collectd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.