Imagebrowser calls new View even when it doesn't need to

Bug #1563567 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon

Bug Description

If I am adding an image to a TinyMCE on a journal entry it still tries to call new View() which is not needed

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6272

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6272
Committed: https://git.mahara.org/mahara/mahara/commit/58bab7897afe34bd775b21150be7c8e42c131a0c
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 58bab7897afe34bd775b21150be7c8e42c131a0c
Author: Robert Lyon <email address hidden>
Date: Wed Mar 30 10:42:58 2016 +1300

Bug 1563567: Calling get_view() when there is no view id

Ends up trying to include lib/view.php when it's not needed

behatnotneeded - existing tests should suffice

Change-Id: Ie337ac11ed92d973364f2f3f24a41df3761da276
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6421

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6421
Committed: https://git.mahara.org/mahara/mahara/commit/ceb6d3330ecf1a0aef7d168757f969f09a4d076a
Submitter: Aaron Wells (<email address hidden>)
Branch: 16.04_STABLE

commit ceb6d3330ecf1a0aef7d168757f969f09a4d076a
Author: Robert Lyon <email address hidden>
Date: Wed Mar 30 10:42:58 2016 +1300

Bug 1563567: Calling get_view() when there is no view id

Ends up trying to include lib/view.php when it's not needed

behatnotneeded - existing tests should suffice

Change-Id: Ie337ac11ed92d973364f2f3f24a41df3761da276
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 58bab7897afe34bd775b21150be7c8e42c131a0c)

Aaron Wells (u-aaronw)
Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.