Mahara

Remove target="_blank" link from webservices OAuth page

Bug #1561239 reported by Aaron Wells
256
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Aaron Wells
Mahara 16.04.1
15.04
Fix Released
Medium
Aaron Wells
Mahara 15.04.7
15.10
Fix Released
Medium
Aaron Wells
Mahara 15.10.3
16.04
Fix Released
Medium
Aaron Wells
Mahara 16.04.1
16.10
Fix Released
Medium
Aaron Wells
Mahara 16.10.0

Bug Description

One item that got overlooked while resolving Bug 1558361, was a target="_blank" link in the webservices OAuth page. This is the code that pops up if Mahara is being used as an OAuth provider, and the link in question leads back to the application that the request is coming from. So, in this circumstance it may be handy to have it open in a new window, but it's not required. So for security reasons, it would be best to remove it.

Aaron Wells (u-aaronw)
information type: Private Security → Public Security
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6270
Committed: https://git.mahara.org/mahara/mahara/commit/f28b3a631f2ee2bb34da4fe13225a8bb40cbfd92
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit f28b3a631f2ee2bb34da4fe13225a8bb40cbfd92
Author: Aaron Wells <email address hidden>
Date: Thu Mar 24 11:55:35 2016 +1300

Remove target="_blank" link from Oauth webservices page

Bug 1561239

Change-Id: I3efca1f6985621af9ae279b75f65a072269f3332

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6416

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.10_STABLE" branch: https://reviews.mahara.org/6417

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/6418

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6417
Committed: https://git.mahara.org/mahara/mahara/commit/9b5fc4d07459ce4295ccc7a157cc0703733bc415
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.10_STABLE

commit 9b5fc4d07459ce4295ccc7a157cc0703733bc415
Author: Aaron Wells <email address hidden>
Date: Thu Mar 24 11:55:35 2016 +1300

Remove target="_blank" link from Oauth webservices page

Bug 1561239

behatnotneeded

Change-Id: I3efca1f6985621af9ae279b75f65a072269f3332
(cherry picked from commit f28b3a631f2ee2bb34da4fe13225a8bb40cbfd92)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6418
Committed: https://git.mahara.org/mahara/mahara/commit/4ce58ef0e6969dbeb7e0bf83ec698274a936060f
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 4ce58ef0e6969dbeb7e0bf83ec698274a936060f
Author: Aaron Wells <email address hidden>
Date: Thu Mar 24 11:55:35 2016 +1300

Remove target="_blank" link from Oauth webservices page

Bug 1561239

behatnotneeded

Change-Id: I3efca1f6985621af9ae279b75f65a072269f3332
(cherry picked from commit f28b3a631f2ee2bb34da4fe13225a8bb40cbfd92)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/6416
Committed: https://git.mahara.org/mahara/mahara/commit/fa9ce1dda84716116ae781e3fda65e1db0784f7b
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit fa9ce1dda84716116ae781e3fda65e1db0784f7b
Author: Aaron Wells <email address hidden>
Date: Thu Mar 24 11:55:35 2016 +1300

Remove target="_blank" link from Oauth webservices page

Bug 1561239

behatnotneeded

Change-Id: I3efca1f6985621af9ae279b75f65a072269f3332
(cherry picked from commit f28b3a631f2ee2bb34da4fe13225a8bb40cbfd92)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public Security information  
Everyone can see this security related information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.