Remove heading style for deleted forum post

Bug #1558874 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Liam
16.04
Fix Released
Medium
Liam
16.10
Fix Released
Medium
Unassigned

Bug Description

When a forum post is deleted, it gets an H5 heading style. I think that is not necessary (even for screen readers) because it's not information that needs to be navigated to in a menu.

It should be sufficient to just have it in a paragraph style.

Tags: bootstrap
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/6334

Liam (liam-sharpe)
Changed in mahara:
assignee: nobody → Liam (liam-sharpe)
status: Confirmed → In Progress
Revision history for this message
Robert Lyon (robertl-9) wrote :

Kristina:

In 15.04 there were a bunch of styles on the .deletedpost class.
Were they left off on purpose when we went to bootstrap?

The styles were:

.deletedpost {
    font-style: italic;
    font-weight: normal;
    margin-top: 0;
    padding: 5px 10px;
    background: #f4f4f4 none repeat scroll 0 0;
    border-radius: 5px;
    color: #666666;
}

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6334
Committed: https://git.mahara.org/mahara/mahara/commit/d16343fd29ca31898ede75f3675984e75bbe6401
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d16343fd29ca31898ede75f3675984e75bbe6401
Author: Liam Sharpe <email address hidden>
Date: Thu Apr 14 13:32:59 2016 +1200

Removed h5 from deleted post in a forum and replaced with a p tag - Bug #1558874

behatnotneeded

Change-Id: I19e0890d0129f5e77cc2f73bfc65a4d3e9c16ce1

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/6358

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/6358
Committed: https://git.mahara.org/mahara/mahara/commit/7ffa49926f05ba5d245509f2acc3cb26b4a1dc60
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit 7ffa49926f05ba5d245509f2acc3cb26b4a1dc60
Author: Liam Sharpe <email address hidden>
Date: Thu Apr 14 13:32:59 2016 +1200

Removed h5 from deleted post in a forum and replaced with a p tag - Bug #1558874

behatnotneeded

Change-Id: I19e0890d0129f5e77cc2f73bfc65a4d3e9c16ce1
(cherry picked from commit d16343fd29ca31898ede75f3675984e75bbe6401)

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.