[SRU] Wrong library path in CMake file for 64bit system

[neomilium]

[Impact]
Packages having a build dependency on liboce-visualization-dev, e.g. freecad, gmsh and netgen, will FTBFS.

[Test Case]
With liboce-visualization-dev 0.17-1-1:
$ sudo apt-get install liboce-visualization-dev
$ ls -d /usr/lib/x86_64-linux-gnu/oce-*
/usr/lib/x86_64-linux-gnu/oce-0.16
$ cat /usr/lib/x86_64-linux-gnu/oce-0.16/OCE04_VisualizationTargets-relwithdebinfo.cmake | grep 'libfreeimage.so'
You will see a line ending: ";/usr/lib/libfreeimage.so"

With liboce-visualization-dev 0.17-1-1ubuntu0.1:
$ sudo apt-get install liboce-visualization-dev
$ ls -d /usr/lib/x86_64-linux-gnu/oce-*
/usr/lib/x86_64-linux-gnu/oce-0.17
$ cat /usr/lib/x86_64-linux-gnu/oce-0.17/OCE04_VisualizationTargets-relwithdebinfo.cmake | grep 'libfreeimage.so'
You will see a line ending: ";/usr/lib/x86_64-linux-gnu/libfreeimage.so"

[Regression Potential]
Minimal, the reverse dependencies of src:oce are the packages that currently FTBFS.

-----------------------------------------------------------------------------

System: Xenial (16.04)
Package: liboce-visualization-dev (0.17.1-1)

liboce-visualization-dev provides CMake files, to be able to CMake-build an application using OCE.

The /usr/lib/x86_64-linux-gnu/oce-0.16/OCE04_VisualizationTargets-relwithdebinfo.cmake file contains this section :

# Import target "TKService" for configuration "RelWithDebInfo"
set_property(TARGET TKService APPEND PROPERTY IMPORTED_CONFIGURATIONS RELWITHDEBINFO)
set_target_properties(TKService PROPERTIES
  IMPORTED_LINK_INTERFACE_LIBRARIES_RELWITHDEBINFO "TKMath;TKernel;TKBRep;TKShHealing;TKGeomBase;TKGeomAlgo;TKG2d;TKG3d;TKTopAlgo;/usr/lib/x86_64-linux-gnu/libX11.so;/usr/lib/x86_64-linux-gnu/libXext.so;/usr/lib/x86_64-linux-gnu/libGLU.so;/usr/lib/x86_64-linux-gnu/libGL.so;/usr/lib/x86_64-linux-gnu/libGLU.so;/usr/lib/x86_64-linux-gnu/libGL.so;/usr/lib/x86_64-linux-gnu/libfreetype.so;/usr/lib/libfreeimage.so"
  IMPORTED_LOCATION_RELWITHDEBINFO "${_IMPORT_PREFIX}/lib/x86_64-linux-gnu/libTKService.so.10.0.0"
  IMPORTED_SONAME_RELWITHDEBINFO "libTKService.so.10"
  )

The "freeimage" library path is wrong on 64bit, according to "dpkg -L libfreeimage-dev" :
/usr/lib/x86_64-linux-gnu/libfreeimage.so
not
/usr/lib/libfreeimage.so as written in liboce-visualization-dev's CMake file.

This bug prevents from building correctly applications that depends on liboce-visualization-dev using CMake.

Tested: Fixing this path fixes build.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Launchpad Janitor (janitor)]

This bug was fixed in the package oce - 0.17.1-1ubuntu1

---------------
oce (0.17.1-1ubuntu1) yakkety; urgency=medium

  * Build-Depend on libfreeimageplus-dev instead of libfreeimage-dev
    in order to build with freeimage >= 3.17.0.
  * Rebuild against freeimage >= 3.17.0 to pick up correct library path
    in OCE04_VisualizationTargets-relwithdebinfo.cmake. (LP: #1556680)

 -- Graham Inggs <email address hidden> Mon, 09 May 2016 15:39:12 +0200

[Graham Inggs (ginggs)]

Debdiff for Xenial SRU attached.

[Brian Murray (brian-murray)]

Hello neomilium, or anyone else affected,

Accepted oce into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/oce/0.17.1-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[neomilium (neomilium)]

Hello Brian,

I confirm that I now can build and use HeeksCAD, with its module HeeksCNC, both depending on OCE.

I used liboce-visualization-dev/xenial-proposed package and regular building of HeeksCAD and HeeksCNC works as expected.

Thanks !

[Launchpad Janitor (janitor)]

This bug was fixed in the package oce - 0.17.1-1ubuntu0.1

---------------
oce (0.17.1-1ubuntu0.1) xenial; urgency=medium

  * Backport 0.17-1-2 from Yakkety as an SRU, including changes:
    + Build-Depend on libfreeimageplus-dev instead of libfreeimage-dev
      in order to build with freeimage >= 3.17.0.
    + Rebuild against freeimage >= 3.17.0 to pick up correct library path
      in OCE04_VisualizationTargets-relwithdebinfo.cmake. (LP: #1556680)
    + Install files in /usr/lib/$(DEB_HOST_MULTIARCH)/oce-0.17. (LP: #1556685)

 -- Graham Inggs <email address hidden> Sun, 22 May 2016 15:08:27 +0200

[Martin Pitt (pitti)]

The verification of the Stable Release Update for oce has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.